Add an AllTrue readiness policy
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks that all conditions are true, and if so marks the object as ready. Signed-off-by: Joakim Recht <[email protected]>
phisco
approved these changes
Nov 17, 2023
|
@recht Thanks for this - I just came across a use case where this will be very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that all conditions are true, and if so marks the object as ready.
Description of your changes
Fixes #124
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Unit tested and deployed locally and verified that deployment objects are marked appropriately when healthy/unhealthy.