generated from ReVanced/revanced-patches-template
-
Notifications
You must be signed in to change notification settings - Fork 75
Closed
Description
| <string name="piko_pref_browser_chooser_desc">Open links with browser chooser instead of using the in-app browser</string> |
This description says "instead of using the in-app browser", but disabling the in-app browser can be achieved with an official Twitter setting.
Due to this description, some users seem to misunderstand that this settings is for disabling the in-app browser.
I suggest this description.
- <string name="piko_pref_browser_chooser_desc">Open links with browser chooser instead of using the in-app browser</string>
+ <string name="piko_pref_browser_chooser_desc">Open links with browser chooser instead of one of the installed browsers</string>This suggestion is partially taken from the patch description, which describes more correctly the how the patch works:
piko/src/main/kotlin/crimera/patches/twitter/link/browserchooser/BrowserChooserPatch.kt
Lines 12 to 17 in 82e912a
| @Patch( | |
| name = "Open browser chooser on opening links", | |
| description = "Instead of open the link directly in one of the installed browsers", | |
| compatiblePackages = [CompatiblePackage("com.twitter.android")], | |
| dependencies = [SettingsPatch::class] | |
| ) |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels