-
-
Notifications
You must be signed in to change notification settings - Fork 59
feat: support add groups for user #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
README.md
Outdated
| groups: | ||
| - group1:2000 | ||
| - group2:2001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better as a map:
| groups: | |
| - group1:2000 | |
| - group2:2001 | |
| groups: | |
| group1: 2000 | |
| group2: 2001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think we could deprecate group in favor of the new field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea, I am trying to implement it.
|
Can you also add a new user with multiple groups in this file https://github.com/crazy-max/docker-samba/blob/master/test/data/config.yml so it's tested in ci workflow? |
auth:
- user: foo
group: foo
uid: 1000
gid: 1000
password: bar
groups: [qux, quux]
- user: yyy
group: xxx
uid: 1100
gid: 1200
password_file: /tmp/yyy_password
group:
qux: 2001
quux: 2002I think this is a better implementation because each user requires a main group. Additionally, this implementation can also ensure that groups are not created repeatedly. |
|
Nice one! You spared me a MR with a more clumsy implementation |
No description provided.