fixup! DBAL3: Implement getServerVersion(), forwarding to PDOCrateDB

Author: amotl

src/Crate/DBAL/Driver/PDOCrate/PDOConnection.php

@@ -52,7 +52,11 @@ public function __construct($dsn, $user = null, $password = null, ?array $option
 
     public function getServerVersion(): string
     {
-        return $this->connection->getServerVersion();
+        try {
+            return $this->connection->getServerVersion();
+        } catch (PDOException $exception) {
+            throw Exception::new($exception);
+        }
     }
 
     public function getNativeConnection(): PDOCrateDB

test/Crate/Test/DBAL/Functional/ConnectionTest.php

@@ -96,18 +96,29 @@ public function testConnect()
         $this->assertEquals('crate', $row['name']);
     }
 
-    public function testGetServerVersion()
+    public function testGetServerVersionNativeConnection()
     {
         // Retrieve server version.
         $serverVersion = $this->_conn->getNativeConnection()->getServerVersion();
+        $this->assertNotNull($serverVersion, 'Server version should not be null');
+        $this->assertNotEquals('0.0.0', $serverVersion, 'Server version should not be 0.0.0');
+        $this->assertMatchesRegularExpression(
+            '/^\d+\.\d+\.\d+/',
+            $serverVersion,
+            'Server version should follow semantic versioning'
+        );
+    }
 
-        // Assume tests are running against CrateDB 5.x or higher, which is likely,
-        // because it will mostly be running on CrateDB nightly.
-        // Otherwise, we will need to populate this value from an external source,
-        // for example an environment variable populated by a CI build matrix.
-        $this->assertTrue(
-            version_compare($serverVersion, '5.0.0', '>='),
-            'Server version should be at least 5.0.0',
+    public function testGetServerVersionWrappedConnection()
+    {
+        // Retrieve server version.
+        $serverVersion = $this->_conn->getWrappedConnection()->getServerVersion();
+        $this->assertNotNull($serverVersion, 'Server version should not be null');
+        $this->assertNotEquals('0.0.0', $serverVersion, 'Server version should not be 0.0.0');
+        $this->assertMatchesRegularExpression(
+            '/^\d+\.\d+\.\d+/',
+            $serverVersion,
+            'Server version should follow semantic versioning'
         );
     }