Rework create_entity.h; more PSP NO3 codeshare (Xeeynamo#2611)

I'm into a small stretch of PSP NO3 functions that are already
decompiled in very high quality, so very little changes to the C are
necessary.

Big change: I noticed that create_entity.h was almost entirely just a
big sequence of `#include` statements, which were including .h files
that were not included anywhere else. I don't see any purpose to pulling
code into a .h file, if it's only included in a single location. I
believe this is a holdover from when we were originally doing deduping
on a function-by-function basis, and not treating full files as shared
units.

Therefore, I have extracted all the contents of these various .h files,
and placed them into the top-level create_entity.h file sequentially.
Overall, this means the code is easier to follow since we don't have so
many nested levels of .h files.

Author: bismurphy

config/splat.pspeu.stno3.yaml

@@ -65,7 +65,9 @@ segments:
       - [0xB3B0, c, no3/e_background_block]
       - [0xB4A8, c, no3/e_unkId16]
       - [0xB580, c, no3_psp/cutscene]
-      - [0xE178, c, no3_psp/working_on]
+      - [0xE178, c, no3/e_lock_camera]
+      - [0xE3D8, c, no3/create_entity]
+      - [0xF380, c, no3_psp/working_on]
       - [0x1AA80, c, no3_psp/e_particles]
       - [0x1F830, c, no3_psp/e_misc]
       - [0x21CC8, c, no3_psp/collision]
@@ -92,7 +94,8 @@ segments:
       - [0x5F070, .data, no3/e_breakable]
       - [0x5F0C0, .data, no3/e_background_block]
       - [0x5F2F0, .data, no3_psp/cutscene]
-      - [0x5F6B8, data]
+      - [0x5F6B8, .data, no3/e_lock_camera]
+      - [0x5F730, data]
       - [0x61600, .rodata, no3/e_castle_door]
       - [0x61618, .rodata, no3/e_outdoor_ents] # EntityPushAlucard
       - [0x61630, .rodata, no3/e_death]
@@ -107,5 +110,7 @@ segments:
       - [0x61BC8, .bss, no3/e_shutting_window]
       - [0x61BD8, .bss, no3/e_breakable]
       - [0x61BE0, .bss, no3_psp/cutscene]
-      - [0x621F0, bss, 621F0]
+      - [0x621F0, .bss, no3/e_lock_camera]
+      - [0x621F8, .bss, no3/create_entity]
+      - [0x62218, bss, 62218]
   - [0x62280]

config/symbols.pspeu.stno3.txt

@@ -106,6 +106,7 @@ EntityWaterDrop = 0x0925EE68;
 EntityRoomForeground = 0x0925F7C0;
 DestroyEntity = 0x0925F8D8;
 AnimateEntity = 0x0925F9F8;
+GetSideToPlayer = 0x0925FC30;
 MoveEntity = 0x0925FCB8;
 AllocEntity = 0x092602D8;
 UnkEntityFunc0 = 0x09260348;
@@ -129,6 +130,7 @@ NO3_EInitBreakable = 0x0926B260;
 g_EInitParticle = 0x0926B280;
 g_EInitSpawner = 0x0926B290;
 g_EInitInteractable = 0x0926B2A0;
+g_EInitLockCamera = 0x0926B2C0;
 g_EInitCommon = 0x0926B2D0;
 g_EInitStInteractable = 0x0926B2F0;
 g_Rooms = 0x0926B528;

include/stage.h

@@ -41,7 +41,6 @@ s32 Random();
 #ifdef VERSION_PC
 void CreateEntityFromEntity(u16 entityId, Entity* source, Entity* entity);
 #endif
-void CreateEntityFromLayout(Entity* entity, LayoutEntity* initDesc);
 void DestroyEntity(Entity*);
 void DestroyEntitiesFromIndex(s16 index);
 void FallEntity(void);

src/st/cen/cen.h

@@ -41,7 +41,6 @@ typedef enum EntityIDs {
 } EntityIDs;
 
 void CreateEntityFromCurrentEntity(u16 entityId, Entity* entity);
-void CreateEntityFromLayout(Entity*, LayoutEntity*);
 u16 GetNormalizedAngle(u16 arg0, u16 arg1, u16 arg2);
 void EntityExplosionVariants(Entity* entity);
 void EntityGreyPuff(Entity* entity);

src/st/chi/ut_create_entity.c

@@ -7,7 +7,6 @@
 
 #include "chi.h"
 #include "../pfn_entity_update.h"
-// func_8019FA64: CreateEntityFromLayout
 // func_8019FB28: CreateEntityWhenInVerticalRange
 // func_8019FC40: CreateEntityWhenInHorizontalRange
 // func_8019FD58: FindFirstEntityToTheRight