Partial fix for #14037 Triplicate warnings for same issue (comparison with bool) (danmar#7727)

Author: chrchr-github

lib/checkcondition.cpp

@@ -2042,8 +2042,9 @@ void CheckCondition::checkCompareValueOutOfTypeRange()
                         break;
                     }
                 }
-                if (error)
-                    compareValueOutOfTypeRangeError(valueTok, typeTok->valueType()->str(), kiv, result);
+                if (!error || diag(tok))
+                    continue;
+                compareValueOutOfTypeRangeError(valueTok, typeTok->valueType()->str(), kiv, result);
             }
         }
     }

test/cfg/std.cpp

@@ -2746,7 +2746,6 @@ void bool_isfinite(float f)
 {
     // cppcheck-suppress compareBoolExpressionWithInt
     // cppcheck-suppress compareValueOutOfTypeRangeError
-    // cppcheck-suppress knownConditionTrueFalse
     if (std::isfinite(f)==123) {}
 }
 
@@ -2769,7 +2768,6 @@ void bool_isgreater(float f1, float f2)
 {
     // cppcheck-suppress compareBoolExpressionWithInt
     // cppcheck-suppress compareValueOutOfTypeRangeError
-    // cppcheck-suppress knownConditionTrueFalse
     if (std::isgreater(f1,f2)==123) {}
 }
 
@@ -2792,7 +2790,6 @@ void bool_isgreaterequal(float f1, float f2)
 {
     // cppcheck-suppress compareBoolExpressionWithInt
     // cppcheck-suppress compareValueOutOfTypeRangeError
-    // cppcheck-suppress knownConditionTrueFalse
     if (std::isgreaterequal(f1, f2)==123) {}
 }
 
@@ -2815,7 +2812,6 @@ void bool_isinf(float f)
 {
     // cppcheck-suppress compareBoolExpressionWithInt
     // cppcheck-suppress compareValueOutOfTypeRangeError
-    // cppcheck-suppress knownConditionTrueFalse
     if (std::isinf(f)==123) {}
 }
 

test/testcondition.cpp

@@ -6231,6 +6231,12 @@ class TestCondition : public TestFixture {
                       "[test.cpp:14:9]: (style) Comparing expression of type 'const unsigned char' against value 255. Condition is always false. [compareValueOutOfTypeRangeError]\n"
                       "[test.cpp:17:9]: (style) Comparing expression of type 'const unsigned char' against value 255. Condition is always true. [compareValueOutOfTypeRangeError]\n",
                       errout_str());
+
+        check("void f(bool b) {\n" // #14037
+              "    if (b != 2) {}\n"
+              "}\n", dinit(CheckOptions, $.s = &settingsUnix64));
+        ASSERT_EQUALS("[test.cpp:2:14]: (style) Comparing expression of type 'bool' against value 2. Condition is always true. [compareValueOutOfTypeRangeError]\n",
+                      errout_str());
     }
 
     void knownConditionCast() {