fixup! fixup! fixup! fixup! fixup! fixup! Fix #1473: warn when fclose() is used as a while loop condition

Author: francois-berder

lib/checkio.cpp

@@ -418,7 +418,7 @@ void CheckIO::fcloseInLoopConditionError(const Token *tok, const std::string &va
 {
     reportError(tok, Severity::warning,
                 "fcloseInLoopCondition",
-                "fclose() should not be used as a loop condition.\n"
+                "fclose() used as loop condition may skip loop body or double-close file handle.\n"
                 "fclose() closes '" + varname + "' each time it is evaluated. On success the loop body might never execute, on failure fclose() might be called again on the already-closed file handle.",
                 CWE910, Certainty::normal);
 }

test/testio.cpp

@@ -544,7 +544,7 @@ class TestIO : public TestFixture {
               "    FILE *a = fopen(\"aa\", \"r\");\n"
               "    while (fclose(a)) {}\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:3:12]: (warning) fclose() should not be used as a loop condition. [fcloseInLoopCondition]\n", errout_str());
+        ASSERT_EQUALS("[test.cpp:3:12]: (warning) fclose() used as loop condition may skip loop body or double-close file handle. [fcloseInLoopCondition]\n", errout_str());
 
         check("void foo() {\n"
               "    FILE *a = fopen(\"aa\", \"r\");\n"
@@ -566,7 +566,7 @@ class TestIO : public TestFixture {
               "    FILE *a = fopen(\"aa\", \"r\");\n"
               "    do {} while (fclose(a));\n"
               "}");
-        ASSERT_EQUALS("[test.cpp:3:18]: (warning) fclose() should not be used as a loop condition. [fcloseInLoopCondition]\n", errout_str());
+        ASSERT_EQUALS("[test.cpp:3:18]: (warning) fclose() used as loop condition may skip loop body or double-close file handle. [fcloseInLoopCondition]\n", errout_str());
 
         // #6823
         check("void foo() {\n"