Skip to content

Commit 86e5e8d

Browse files
authored
Merge pull request opencv#15993 from midjji:master
This is a correction of the previously missleading documentation and a warning related to a common calibration failure described in issue 15992 * corrected incorrect description of failed calibration state. see issue 15992 * calib3d: apply suggestions from code review by catree
1 parent 591f427 commit 86e5e8d

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

modules/calib3d/include/opencv2/calib3d.hpp

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,18 @@ v = f_y \times y'' + c_y
118118
tangential distortion coefficients. \f$s_1\f$, \f$s_2\f$, \f$s_3\f$, and \f$s_4\f$, are the thin prism distortion
119119
coefficients. Higher-order coefficients are not considered in OpenCV.
120120
121-
The next figures show two common types of radial distortion: barrel distortion (typically \f$ k_1 < 0 \f$) and pincushion distortion (typically \f$ k_1 > 0 \f$).
121+
The next figures show two common types of radial distortion: barrel distortion
122+
(\f$ 1 + k_1 r^2 + k_2 r^4 + k_3 r^6 \f$ monotonically decreasing)
123+
and pincushion distortion (\f$ 1 + k_1 r^2 + k_2 r^4 + k_3 r^6 \f$ monotonically increasing).
124+
Radial distortion is always monotonic for real lenses,
125+
and if the estimator produces a non monotonic result,
126+
this should be considered a calibration failure.
127+
More generally, radial distortion must be monotonic and the distortion function, must be bijective.
128+
A failed estimation result may look deceptively good near the image center
129+
but will work poorly in e.g. AR/SFM applications.
130+
The optimization method used in OpenCV camera calibration does not include these constraints as
131+
the framework does not support the required integer programming and polynomial inequalities.
132+
See [issue #15992](https://github.com/opencv/opencv/issues/15992) for additional information.
122133
123134
![](pics/distortion_examples.png)
124135
![](pics/distortion_examples2.png)

0 commit comments

Comments
 (0)