Better injection mechanism and tasks tests (#5)

- Update schema verification code to be more readable
- Injection now has source and destination configurable folders
- Remove code injection for build, leave it for testing
- Do not modify submitted code, create temp folders instead
- Add a temp folder creator class that cleans up after itself
- Add timeouts for test and build
- Better tests for tasks and checker

Author: niosus

Diff for: homework_checker/checker.py

@@ -49,7 +49,7 @@ def check_homework(self: "Checker", homework_node: dict) -> HomeworkResultDict:
             )
             if not task:
                 continue
-            results[task.name] = task.check_all_tests()
+            results[task.name] = task.check()
         return results
 
     def check_all_homeworks(self: "Checker") -> Dict[str, HomeworkResultDict]:

Diff for: homework_checker/schema_manager.py

@@ -25,47 +25,49 @@ class SchemaManager:
 
     def __init__(self: SchemaManager, file_name: Path):
         """Create a schema for my tests."""
-        # TODO(igor): simplify by moving parts out of here into separate variables.
+
+        injection_schema = {
+            Tags.INJECT_SOURCE_TAG: str,
+            Tags.INJECT_DESTINATION_TAG: str,
+        }
+
+        test_schema = {
+            Tags.NAME_TAG: str,
+            Optional(Tags.INPUT_TAG): str,
+            Optional(Tags.INJECT_FOLDER_TAG): [injection_schema],
+            Optional(Tags.RUN_GTESTS_TAG, default=False): bool,
+            Optional(Tags.EXPECTED_OUTPUT_TAG): Or(str, float, int),
+            Optional(Tags.TIMEOUT_TAG, default=60): float,
+        }
+
+        task_schema = {
+            Tags.NAME_TAG: str,
+            Tags.LANGUAGE_TAG: Or(LangTags.CPP, LangTags.BASH),
+            Tags.FOLDER_TAG: str,
+            Optional(Tags.OUTPUT_TYPE_TAG, default=OutputTags.STRING): Or(
+                OutputTags.STRING, OutputTags.NUMBER
+            ),
+            Optional(Tags.COMPILER_FLAGS_TAG, default="-Wall"): str,
+            Optional(Tags.BINARY_NAME_TAG, default="main"): str,
+            Optional(Tags.PIPE_TAG, default=""): str,
+            Optional(Tags.BUILD_TYPE_TAG, default=BuildTags.CMAKE): Or(
+                BuildTags.CMAKE, BuildTags.SIMPLE
+            ),
+            Optional(Tags.BUILD_TIMEOUT_TAG, default=60): float,
+            Optional(Tags.TESTS_TAG): [test_schema],
+        }
+
+        homework_schema = {
+            Tags.NAME_TAG: str,
+            Tags.FOLDER_TAG: str,
+            Optional(Tags.DEADLINE_TAG, default=MAX_DATE_STR): str,
+            Tags.TASKS_TAG: [task_schema],
+        }
+
         self.__schema = Schema(
             {
                 Tags.FOLDER_TAG: str,
-                Tags.HOMEWORKS_TAG: [
-                    {
-                        Tags.NAME_TAG: str,
-                        Tags.FOLDER_TAG: str,
-                        Optional(Tags.DEADLINE_TAG, default=MAX_DATE_STR): str,
-                        Tags.TASKS_TAG: [
-                            {
-                                Tags.NAME_TAG: str,
-                                Tags.LANGUAGE_TAG: Or(LangTags.CPP, LangTags.BASH),
-                                Tags.FOLDER_TAG: str,
-                                Optional(
-                                    Tags.OUTPUT_TYPE_TAG, default=OutputTags.STRING
-                                ): Or(OutputTags.STRING, OutputTags.NUMBER),
-                                Optional(Tags.COMPILER_FLAGS_TAG, default="-Wall"): str,
-                                Optional(Tags.BINARY_NAME_TAG, default="main"): str,
-                                Optional(Tags.PIPE_TAG, default=""): str,
-                                Optional(
-                                    Tags.BUILD_TYPE_TAG, default=BuildTags.CMAKE
-                                ): Or(BuildTags.CMAKE, BuildTags.SIMPLE),
-                                Optional(Tags.INJECT_FOLDER_TAG): [str],
-                                Optional(Tags.TESTS_TAG): [
-                                    {
-                                        Tags.NAME_TAG: str,
-                                        Optional(Tags.INPUT_TAG): str,
-                                        Optional(Tags.INJECT_FOLDER_TAG): [str],
-                                        Optional(
-                                            Tags.RUN_GTESTS_TAG, default=False
-                                        ): bool,
-                                        Optional(Tags.EXPECTED_OUTPUT_TAG): Or(
-                                            str, float, int
-                                        ),
-                                    }
-                                ],
-                            }
-                        ],
-                    }
-                ],
+                Tags.HOMEWORKS_TAG: [homework_schema],
             }
         )
         yaml = YAML()

Diff for: homework_checker/schema_tags.py

@@ -6,13 +6,16 @@ class Tags:
     """List of tags available."""
 
     BINARY_NAME_TAG = "binary_name"
+    BUILD_TIMEOUT_TAG = "build_timeout"
     BUILD_TYPE_TAG = "build_type"
     COMPILER_FLAGS_TAG = "compiler_flags"
     DEADLINE_TAG = "submit_by"
     EXPECTED_OUTPUT_TAG = "expected_output"
     FOLDER_TAG = "folder"
     HOMEWORKS_TAG = "homeworks"
+    INJECT_DESTINATION_TAG = "destination"
     INJECT_FOLDER_TAG = "inject_folders"
+    INJECT_SOURCE_TAG = "source"
     INPUT_TAG = "input_args"
     LANGUAGE_TAG = "language"
     NAME_TAG = "name"
@@ -21,6 +24,7 @@ class Tags:
     RUN_GTESTS_TAG = "run_google_tests"
     TASKS_TAG = "tasks"
     TESTS_TAG = "tests"
+    TIMEOUT_TAG = "timeout"
 
 
 class OutputTags: