[LWG 1] P3504R0 C++ Standard Library Ready Issues #7459

burblebee · 2024-11-28T09:29:44Z

Fixes #7413.

Notes: I assumed the Tentatively Ready issues were to be applied also.

Also fixes cplusplus/papers#1983

…inefficient

…rator new should not be constrained

[specialized.algorithms.general] Changed to "function templates" as per #6265.

…_carry_engine code

…ared_for_overwrite/std::allocate_shared_for_overwrite

[ostream.formatted.print] New paragraphs not numbered as indicated since they are part of the \effects clause.

… of std::memcpy

…turn type

…able entity should consider decaying

…llocate_shared

[optional.assign] Removed "<T>" from declaration to match that in synopsis.

…lloc>)'s nested generator may be ill-formed

…not yet marked freestanding

…n type as bool

[template.bitset.general] [vector.bool.pspc] bitset already removed.

…ast one type

jwakely · 2024-11-28T17:33:49Z

Notes: I assumed the Tentatively Ready issues were to be applied also.

Yes: "Apply the changes for all Ready and Tentatively Ready issues in P3504R0 (C++ Standard Library Ready Issues to be moved in Wrocław, Nov. 2024) to the C++ working paper."

CaseyCarter · 2024-12-09T23:52:09Z

source/iostreams.tex

+\tcode{os} is a stream that refers to a terminal that
+is only capable of displaying Unicode via a native Unicode API,


Per discussion on the LWG reflectors, "only" is ambiguous here:

Suggested change

\tcode{os} is a stream that refers to a terminal that

is only capable of displaying Unicode via a native Unicode API,

\tcode{os} is a stream that refers to a terminal that

is capable of displaying Unicode only via a native Unicode API,

("Get out with this change that's not in the ingress paper and come back after the motion is merged" is a perfectly valid response to this suggestion.)

This change was requested and agreed to on the LWG reflector. I think it qualifies as an editorial improvement that clarifies the intended meaning.

Yes, that's better. done.

It looks like this change hasn't been pushed to the branch though?

Line 7849 needs the same change.

… LWG discussion

jwakely · 2024-12-13T17:03:24Z

source/ranges.tex

@@ -16995,6 +16995,9 @@
    template<class R2, class V2, class Alloc2, class Unused>
      requires @\libconcept{same_as}@<typename generator<R2, V2, Alloc2>::yielded, yielded>
        auto yield_value(ranges::elements_of<generator<R2, V2, Alloc2>&&, Unused> g) noexcept;
+    template<class R2, class V2, class Alloc2, class Unused>
+      requires same_as<typename generator<R2, V2, Alloc2>::yielded, yielded>


Do we want to use \libconcept{same_as} or was it intentionally omitted because it's on the declaration immediately above?

We want \libconcept everywhere a library concept appears. This is refactoring-safe and if we ever want to have color highlighting for concept names (for example), we actually can do that.

jwakely · 2024-12-13T17:03:55Z

source/ranges.tex

@@ -17122,6 +17125,9 @@
 template<class R2, class V2, class Alloc2, class Unused>
  requires @\libconcept{same_as}@<typename generator<R2, V2, Alloc2>::yielded, yielded>
  auto yield_value(ranges::elements_of<generator<R2, V2, Alloc2>&&, Unused> g) noexcept;
+template<class R2, class V2, class Alloc2, class Unused>
+  requires same_as<typename generator<R2, V2, Alloc2>::yielded, yielded>


Same question about \libconcept here

Same answer. \libconcept, please

jwakely · 2024-12-13T17:43:34Z

source/containers.tex

@@ -9261,8 +9261,6 @@

    // bit reference
    class @\libmember{reference}{vector<bool>}@ {
-      constexpr reference() noexcept;


For the record, the friend declarations were removed by #6427

jwakely · 2024-12-13T17:48:27Z

source/iterators.tex

@@ -1969,6 +1969,7 @@
 \item \tcode{to_address(a) == addressof(*a)},
 \item \tcode{to_address(b) == to_address(a) + D(b - a)},
 \item \tcode{to_address(c) == to_address(a) + D(c - a)},
+\item \tcode{address(I\{\})} is well-defined,


This should be to_address not address

jwakely

Move two occurrences of "only" to later in the sentence, for more goodly Englishing.

Change address to to_address.

Use \libconcept for same_as, twice

jwakely · 2024-12-14T22:22:17Z

source/iostreams.tex

+\begin{itemize}
+\item
+If \tcode{stream} refers to a terminal that
+is only capable of displaying Unicode via a native Unicode API,


Suggested change

is only capable of displaying Unicode via a native Unicode API,

is capable of displaying Unicode only via a native Unicode API,

burblebee added 30 commits November 27, 2024 23:08

LWG3436 std::construct_at should support arrays

2a43f62

LWG3899 co_yielding elements of an lvalue generator is unnecessarily …

1ef0eb3

…inefficient

LWG3900 The allocator_arg_t overloads of generator::promise_type::ope…

a5f24f3

…rator new should not be constrained

LWG3918 std::uninitialized_move/_n and guaranteed copy elision

8dc94df

[specialized.algorithms.general] Changed to "function templates" as per #6265.

LWG4014 LWG 3809 changes behavior of some existing std::subtract_with…

562a3be

…_carry_engine code

LWG4024 Underspecified destruction of objects created in std::make_sh…

63bf48b

…ared_for_overwrite/std::allocate_shared_for_overwrite

LWG4027 possibly-const-range should prefer returning const R&

0cc6ae5

LWG4044 Confusing requirements for std::print on POSIX platforms

60e8aa7

[ostream.formatted.print] New paragraphs not numbered as indicated since they are part of the \effects clause.

LWG4064 Clarify that std::launder is not needed when using the result…

a77c52d

… of std::memcpy

LWG4072 std::optional comparisons: constrain harder

4ed7697

LWG4085 ranges::generate_random's helper lambda should specify the re…

8aa46dc

…turn type

LWG4112 has-arrow should required operator->() to be const-qualified

136065f

LWG4134 Issue with Philox algorithm specification

4dc10a5

LWG4154 The Mandates for std::packaged_task's constructor from a call…

2137507

…able entity should consider decaying

LWG4164 Missing guarantees for forward_list modifiers

71b9526

LWG3216 Rebinding the allocator before calling construct/destroy in a…

de80974

…llocate_shared

LWG3886 Monad mo' problems

3edfff7

[optional.assign] Removed "<T>" from declaration to match that in synopsis.

LWG4084 std::fixed ignores std::uppercase

30068ea

LWG4088 println ignores the locale imbued in std::ostream

0ec58e8

LWG4113 Disallow has_unique_object_representations<Incomplete[]>

d44cfff

LWG4119 generator::promise_type::yield_value(ranges::elements_of<R, A…

21f988b

…lloc>)'s nested generator may be ill-formed

LWG4124 Cannot format zoned_time with resolution coarser than seconds

c1445bc

LWG4126 Some feature-test macros for fully freestanding features are …

3ed48ae

…not yet marked freestanding

LWG4135 The helper lambda of std::erase for list should specify retur…

ba5e36f

…n type as bool

LWG4140 Useless default constructors for bit reference types

0116785

[template.bitset.general] [vector.bool.pspc] bitset already removed.

LWG4141 Improve prohibitions on "additional storage"

5437db0

LWG4142 format_parse_context::check_dynamic_spec should require at le…

49fc523

…ast one type

LWG4144 Disallow unique_ptr<T&, D>

8c53feb

LWG4147 Precondition on inplace_vector::emplace

0f752fb

LWG4148 unique_ptr::operator* should not allow dangling references

72ba8da

burblebee added 4 commits November 28, 2024 03:25

LWG4153 Fix extra "-1" for philox_engine::max()

d6a7096

LWG4157 The resolution of LWG3465 was damaged by P2167R3

aa454e0

LWG4169 std::atomic<T>'s default constructor should be constrained

c70aad0

LWG4170 contiguous_iterator should require to_address(I{})

b3e60b8

burblebee marked this pull request as ready for review November 28, 2024 11:43

jensmaurer added this to the post-2024-11 milestone Dec 4, 2024

CaseyCarter reviewed Dec 9, 2024

View reviewed changes

[ostream.formatted.print] Remove "only" in wording for LWG4044 as per…

7820989

… LWG discussion

burblebee requested review from jwakely and CaseyCarter December 13, 2024 01:16

jwakely reviewed Dec 13, 2024

View reviewed changes

jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Dec 13, 2024

jwakely reviewed Dec 13, 2024

View reviewed changes

jwakely requested changes Dec 13, 2024

View reviewed changes

jwakely reviewed Dec 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LWG 1] P3504R0 C++ Standard Library Ready Issues #7459

[LWG 1] P3504R0 C++ Standard Library Ready Issues #7459

burblebee commented Nov 28, 2024 •

edited by jensmaurer

Loading

jwakely commented Nov 28, 2024

CaseyCarter Dec 9, 2024 •

edited

Loading

jwakely Dec 10, 2024

burblebee Dec 13, 2024

jwakely Dec 13, 2024

jwakely Dec 13, 2024

jwakely Dec 13, 2024

jensmaurer Dec 13, 2024

jwakely Dec 13, 2024

jensmaurer Dec 13, 2024

jwakely Dec 13, 2024

jwakely Dec 13, 2024

jwakely left a comment

jwakely Dec 14, 2024

		\tcode{os} is a stream that refers to a terminal that
		is only capable of displaying Unicode via a native Unicode API,

	is only capable of displaying Unicode via a native Unicode API,
	is capable of displaying Unicode only via a native Unicode API,

[LWG 1] P3504R0 C++ Standard Library Ready Issues #7459

Are you sure you want to change the base?

[LWG 1] P3504R0 C++ Standard Library Ready Issues #7459

Conversation

burblebee commented Nov 28, 2024 • edited by jensmaurer Loading

jwakely commented Nov 28, 2024

CaseyCarter Dec 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jwakely left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

burblebee commented Nov 28, 2024 •

edited by jensmaurer

Loading

CaseyCarter Dec 9, 2024 •

edited

Loading