Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-11 CWG Motion 8] P3176R1 The Oxford variadic comma #7434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Eisenwave
Copy link
Contributor

@Eisenwave Eisenwave changed the title P3176r1 P3176R1 The Oxford variadic comma Nov 24, 2024
@Eisenwave Eisenwave changed the title P3176R1 The Oxford variadic comma Merge CWG Motion 8 - P3176R1 The Oxford variadic comma Nov 24, 2024
@Eisenwave Eisenwave changed the title Merge CWG Motion 8 - P3176R1 The Oxford variadic comma Merge 2024-11 CWG Motion 8 - P3176R1 The Oxford variadic comma Nov 24, 2024
@jensmaurer
Copy link
Member

Please squash and rebase and use the commit message format as described here:

https://github.com/cplusplus/draft/wiki/Commit-message-format

@jensmaurer jensmaurer added this to the post-2024-11 milestone Nov 24, 2024
@jensmaurer jensmaurer added changes requested Changes to the wording or approach have been requested and not yet applied. and removed changes requested Changes to the wording or approach have been requested and not yet applied. labels Dec 4, 2024
@jensmaurer jensmaurer changed the title Merge 2024-11 CWG Motion 8 - P3176R1 The Oxford variadic comma [2024-11 CWG Motion 8] P3176R1 The Oxford variadic comma Dec 4, 2024
A \grammarterm{parameter-declaration-clause}
of the form
\grammarterm{parameter-declaration-list} \tcode{...}
is deprecated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a iref to [depr.ellipsis.comma]?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually do that on this PR? I have been told that any editorial fixes that would change the approved wording should be done as a separate follow-up PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be a separate commit in the same pull request,
maybe with the title "[section.label] Add cross-reference to [xyz.abc]"
or so.

This way, we clearly separate the approved wording from the paper from add-on editorial fixes.


A \grammarterm{parameter-declaration-clause}
of the form
\grammarterm{parameter-declaration-list} \tcode{...}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, I think this should have an iref back to [dcl.fct] (I think that is the right clause)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2024-11 CWG Motion 8] P3176R1 The Oxford variadic comma P3176 R0 The Oxford variadic comma
3 participants