-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2024-11 CWG Motion 8] P3176R1 The Oxford variadic comma #7434
base: main
Are you sure you want to change the base?
Conversation
Please squash and rebase and use the commit message format as described here: https://github.com/cplusplus/draft/wiki/Commit-message-format |
A \grammarterm{parameter-declaration-clause} | ||
of the form | ||
\grammarterm{parameter-declaration-list} \tcode{...} | ||
is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a iref to [depr.ellipsis.comma]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we actually do that on this PR? I have been told that any editorial fixes that would change the approved wording should be done as a separate follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be a separate commit in the same pull request,
maybe with the title "[section.label] Add cross-reference to [xyz.abc]"
or so.
This way, we clearly separate the approved wording from the paper from add-on editorial fixes.
|
||
A \grammarterm{parameter-declaration-clause} | ||
of the form | ||
\grammarterm{parameter-declaration-list} \tcode{...} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, I think this should have an iref back to [dcl.fct] (I think that is the right clause)
Fixes #7412
Fixes cplusplus/papers#1839