Implement Python checks and fix some violations

eisenwave · eisenwave · commit 51dfd10c8696 · 2026-06-17T20:05:34.000+02:00
diff --git a/.github/workflows/check-python.yml b/.github/workflows/check-python.yml
@@ -0,0 +1,33 @@
+name: check-python
+
+on:
+  pull_request:
+    paths:
+      - "tools/**.py"
+      - "pyrightconfig.json"
+      - ".github/workflows/check-python.yml"
+  push:
+    paths:
+      - "tools/**.py"
+      - "pyrightconfig.json"
+      - ".github/workflows/check-python.yml"
+
+jobs:
+  pyright:
+    name: Pyright type check
+    runs-on: ubuntu-24.04
+
+    steps:
+      - name: checkout
+        uses: actions/checkout@v6
+
+      - name: setup Node
+        uses: actions/setup-node@v6
+        with:
+          node-version: "20"
+
+      - name: install pyright
+        run: npm install -g pyright
+
+      - name: run pyright
+        run: pyright
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -33,6 +33,9 @@ jobs:
       - name: check-source.sh
         run: ../tools/check-source.sh
 
+      - name: check-source.py
+        run: python3 ../tools/check-source.py
+
       - name: update brew
         if: matrix.cfg.os == 'macos-15'
         run: brew update
diff --git a/.gitignore b/.gitignore
@@ -22,3 +22,4 @@ tools/sections
 *.synctex.gz
 *.synctex*
 .check.stamp
+__pycache__
diff --git a/pyrightconfig.json b/pyrightconfig.json
@@ -0,0 +1,14 @@
+{
+    "include": [
+        "tools/*.py"
+    ],
+    "typeCheckingMode": "strict",
+    "reportMissingTypeStubs": false,
+    "reportUnknownMemberType": false,
+    "reportUnknownArgumentType": false,
+    "reportUnknownVariableType": false,
+    "reportUnknownParameterType": false,
+    "reportUnusedImport": true,
+    "reportUnusedVariable": true,
+    "pythonVersion": "3.11"
+}
diff --git a/source/algorithms.tex b/source/algorithms.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[algorithms]{Algorithms library}
 
 \rSec1[algorithms.general]{General}
diff --git a/source/assets/example_01.tex b/source/assets/example_01.tex
@@ -1,3 +1,4 @@
+%NOCHECKBEGIN
 \documentclass[9pt]{standalone}
 
 \usepackage{fontspec}
diff --git a/source/assets/example_02.tex b/source/assets/example_02.tex
@@ -1,3 +1,4 @@
+%NOCHECKBEGIN
 \documentclass[9pt]{standalone}
 
 \usepackage{fontspec}
diff --git a/source/assets/example_03.tex b/source/assets/example_03.tex
@@ -1,3 +1,4 @@
+%NOCHECKBEGIN
 \documentclass[9pt]{standalone}
 
 \usepackage{fontspec}
diff --git a/source/assets/example_04.tex b/source/assets/example_04.tex
@@ -1,3 +1,4 @@
+%NOCHECKBEGIN
 \documentclass[9pt]{standalone}
 
 \usepackage{fontspec}
diff --git a/source/assets/example_05.tex b/source/assets/example_05.tex
@@ -1,3 +1,4 @@
+%NOCHECKBEGIN
 \documentclass[9pt]{standalone}
 
 \usepackage{fontspec}
diff --git a/source/assets/example_06.tex b/source/assets/example_06.tex
@@ -1,3 +1,4 @@
+%NOCHECKBEGIN
 \documentclass[9pt]{standalone}
 
 \usepackage{fontspec}
diff --git a/source/basic.tex b/source/basic.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \rSec0[basic]{Basics}
 
 \gramSec[gram.basic]{Basics}
diff --git a/source/classes.tex b/source/classes.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \rSec0[class]{Classes}%
 \indextext{class|(}
 
diff --git a/source/compatibility.tex b/source/compatibility.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \infannex{diff}{Compatibility}
 
 \rSec1[diff.cpp23]{\Cpp{} and ISO \CppXXIII{}}
diff --git a/source/concepts.tex b/source/concepts.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[concepts]{Concepts library}
 
 \rSec1[concepts.general]{General}
diff --git a/source/containers.tex b/source/containers.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[containers]{Containers library}
 
 \rSec1[containers.general]{General}
diff --git a/source/declarations.tex b/source/declarations.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \rSec0[dcl]{Declarations}%
 \indextext{declaration|(}
 
diff --git a/source/diagnostics.tex b/source/diagnostics.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[diagnostics]{Diagnostics library}
 
 \rSec1[diagnostics.general]{General}
diff --git a/source/exceptions.tex b/source/exceptions.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \rSec0[except]{Exception handling}%
 \indextext{exception handling|(}
 
diff --git a/source/exec.tex b/source/exec.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[exec]{Execution control library}
 
 \rSec1[exec.general]{General}
diff --git a/source/expressions.tex b/source/expressions.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \rSec0[expr]{Expressions}
 
 \gramSec[gram.expr]{Expressions}
diff --git a/source/future.tex b/source/future.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \normannex{depr}{Compatibility features}
 
 \rSec1[depr.general]{General}
diff --git a/source/grammar.tex b/source/grammar.tex
@@ -1,3 +1,4 @@
+%NOCHECKBEGIN(lib-*)
 \infannex{gram}{Grammar summary}
 
 \rSec1[gram.general]{General}
diff --git a/source/intro.tex b/source/intro.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 
 \clearpage
 \bigskip\noindent\textlarger{\textbf{Programming languages --- \Cpp{}}}
diff --git a/source/iostreams.tex b/source/iostreams.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[input.output]{Input/output library}
 
 \rSec1[input.output.general]{General}
diff --git a/source/iterators.tex b/source/iterators.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[iterators]{Iterators library}
 
 \rSec1[iterators.general]{General}
diff --git a/source/layout.tex b/source/layout.tex
@@ -74,6 +74,7 @@
 % Register our intent to number the next paragraph. Don't actually number it
 % yet, because we might have a paragraph break before we see its contents (for
 % example, if the paragraph begins with a note or example).
+%EXPECTCHECKNEXTLINE(base-pnum-alone)
 \def\pnum{%
 \global\def\maybeaddpnum{\global\def\maybeaddpnum{}\parabullnum{Paras}{0pt}}%
 \everypar=\expandafter{\the\everypar\maybeaddpnum}%
diff --git a/source/lex.tex b/source/lex.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \rSec0[lex]{Lexical conventions}
 
 \gramSec[gram.lex]{Lexical conventions}
diff --git a/source/limits.tex b/source/limits.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \infannex{implimits}{Implementation quantities}
 
 \pnum
diff --git a/source/macros.tex b/source/macros.tex
@@ -1,4 +1,6 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN
+%NOCHECKEND(text-*)
 
 % Definitions and redefinitions of special commands
 %
diff --git a/source/memory.tex b/source/memory.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[mem]{Memory management library}
 
 \rSec1[mem.general]{General}
diff --git a/source/meta.tex b/source/meta.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[meta]{Metaprogramming library}
 
 \rSec1[meta.general]{General}
diff --git a/source/modules.tex b/source/modules.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \rSec0[module]{Modules}%
 
 \gramSec[gram.module]{Modules}
diff --git a/source/numerics.tex b/source/numerics.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[numerics]{Numerics library}
 
 \rSec1[numerics.general]{General}
@@ -17724,6 +17725,7 @@
 
 \pnum
 \constraints
+%NOCHECKBEGIN(base-tcode-exposid)
 Every type in the parameter pack \tcode{Flags} is one of \tcode{\exposid{convert-flag}},
 \tcode{\exposid{aligned-flag}}, or \tcode{\exposid{over\-aligned-\brk{}flag}<N>}.
 
@@ -19889,6 +19891,7 @@
 where \tcode{\exposid{simd-select-impl}} is found by argument-dependent
 lookup\iref{basic.lookup.argdep} contrary to \ref{contents}.
 \end{itemdescr}
+%NOCHECKEND(base-tcode-exposid)
 
 \rSec3[simd.math]{Mathematical functions}
 
@@ -20946,7 +20949,8 @@
 \tcode{basic_mask<Bytes, Abi>} is trivially copyable.
 
 \pnum
-\recommended Implementations should support implicit conversions between
+\recommended
+Implementations should support implicit conversions between
 specializations of \tcode{basic_mask} and appropriate \impldef{conversions
 of \tcode{basic_mask} from/to implementation-specific vector types} types.
 \begin{note}
diff --git a/source/overloading.tex b/source/overloading.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \rSec0[over]{Overloading}%
 \indextext{overloading|(}
 
@@ -3845,11 +3846,11 @@
 In this subclause, the term
 \defn{promoted integral type}
 is used to refer to those cv-unqualified integral types which are preserved by
-integral promotion\iref{conv.prom} (including e.g.
+integral promotion\iref{conv.prom} (including e.g.,
 \tcode{int}
 and
 \tcode{long}
-but excluding e.g.
+but excluding e.g.,
 \tcode{char}).
 \begin{note}
 In all cases where a promoted integral type is
diff --git a/source/preprocessor.tex b/source/preprocessor.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \rSec0[cpp]{Preprocessing directives}%
 \indextext{preprocessing directive|(}
 
diff --git a/source/statements.tex b/source/statements.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \rSec0[stmt]{Statements}%
 \indextext{statement|(}
 
diff --git a/source/strings.tex b/source/strings.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[strings]{Strings library}
 
 \rSec1[strings.general]{General}
diff --git a/source/tables.tex b/source/tables.tex
@@ -1,5 +1,6 @@
 %!TEX root = std.tex
 % Definitions of table environments
+%NOCHECKBEGIN(base-env-balancing)
 
 %%--------------------------------------------------
 %% Table environments
diff --git a/source/templates.tex b/source/templates.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \rSec0[temp]{Templates}%
 \indextext{template|(}
 
diff --git a/source/text.tex b/source/text.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 
 \rSec0[text]{Text processing library}
 
diff --git a/source/threads.tex b/source/threads.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[thread]{Concurrency support library}
 
 \rSec1[thread.general]{General}
diff --git a/source/time.tex b/source/time.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 \rSec0[time]{Time library}
 
 \rSec1[time.general]{General}
diff --git a/source/uax31.tex b/source/uax31.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-*)
 \infannex{uaxid}{Conformance with \UAX{31}}
 
 \rSec1[uaxid.general]{General}
diff --git a/source/utilities.tex b/source/utilities.tex
@@ -1,4 +1,5 @@
 %!TEX root = std.tex
+%NOCHECKBEGIN(lib-ranges-*)
 
 \rSec0[utilities]{General utilities library}
 
diff --git a/tools/check-source.py b/tools/check-source.py
diff --git a/tools/test-checks.tex b/tools/test-checks.tex

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`%!TEX root = std.tex`
	`2`	`+%NOCHECKBEGIN(lib-ranges-*)`
`2`	`3`	`\rSec0[algorithms]{Algorithms library}`
`3`	`4`
`4`	`5`	`\rSec1[algorithms.general]{General}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+%NOCHECKBEGIN`
`1`	`2`	`\documentclass[9pt]{standalone}`
`2`	`3`
`3`	`4`	`\usepackage{fontspec}`