[Bug]: Reverse progress bar direction under Progress Effects doesn't change the Both Ends effect
#210
Labels
Milestone
Comments
CoryCharlton
added a commit
to CoryCharlton/OctoPrint-WS281x_LED_Status
that referenced
this issue
Jan 27, 2023
…the left/right `reverse_progress` parameter based on that
|
Solution is implemented in PR #212 |
cp2004
added a commit
that referenced
this issue
Jan 29, 2023
* Fixes issue #210 by adding the `reverse` parameter and setting the left/right `reverse_progress` parameter based on that * Refactored progress bar effect into a shared method * Refactored both ends effect to use the shared progress_bar_impl method * Added the "From Center" progress effect * Added the "Reversed Progress Bar" progress effect * Remove `Reverse progress bar direction` from the UI and from being passed into the `EffectRunner` *↔️ Add settings migration * 🎨 reverse is already a bool Closes #209 Closes #210 --------- Co-authored-by: Charlie Powell <[email protected]>
cp2004
added
solved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
Reverse progress bar directionunderProgress Effectsdoesn't change theBoth Endseffect.I'm not sure if this is the intended behavior but I expected the progress to "grow" from the center rather than the end when I selected
Reverse progress bar directionSteps to reproduce
No response
What happened instead?
The progress continues to "grow" from the ends.
Plugin version
0.8.1
OctoPrint version
1.8.6
(if relevant) OctoPi version
1.0.0 RC3
Log Files & Screenshots
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: