Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Refresh/reset button to push all status to WLED #34

Open
SVLoneStar opened this issue Apr 29, 2021 · 2 comments
Open

[Request] Refresh/reset button to push all status to WLED #34

SVLoneStar opened this issue Apr 29, 2021 · 2 comments
Labels
request New feature or request

Comments

@SVLoneStar
Copy link

SVLoneStar commented Apr 29, 2021

When switching on the WLED Wemos in the middle of a print, status is not fully synched to the LED stripe.

I have 3 segments defined...the one configured to show the printing progress gets updated, but the other two (meant to show status 'printing') are left to the previous pattern (whatever that was).

Steps to reproduce

  1. configure e.g. 3 segments, assign segment 0 and 2 to show a specific color for 'Print Started
  2. Start a print with WLED (Wemos) turned off
  3. In the middle of the print, turn on the Wemos

What did you expect to happen
I'd expect that ever so often, the complete configuration for the stripe gets sent to the WLED Wemos, and not only updates for the 'Progress Effect' are being sent.

Logs and screenshots

Version of plugin and OctoPrint

OctoPrint 1.6.0, WLED plugin 0.1.0

(If applicable) Browser version & browser error console

Additional context

Updating the complete stripe by switching on/off the plugin in OctoPrint's top bar would be sufficient for me. ;-)
Modifying the configuration and saving it updates the complete stripe, also mid-print.

@cp2004
Copy link
Owner

cp2004 commented Apr 29, 2021

Less bug, more intentional and the way OctoPrint's event system works. Yes it could probably be clearer how this works, for sure.

Each of the effects you get to see in the settings is event-driven. It will only send requests across the network to change the LEDs, when there is a new effect. The printing progress event is obviously changing far more frequently, but it still works the same way, it will only change if there is a new data. Modifying the configuration is also treated this way, it actually replays the last event to make sure WLED is up to date with the changes made in the OctoPrint settings.

I want to work on it a bit more to make the behaviour consistent, but I'm not going to constantly push the last event back to the printer all the time. As it stands, the plugin allows for a lot of freedom with doing other things with your WLED device.

TL,DR; Yes, there is something to be done but I haven't decided what to do about it yet.

Added just before I hit comment: Maybe a button to refresh the LED strip, with whatever the plugin thinks should be on there currently. I'll think about it 🙂

@SVLoneStar
Copy link
Author

SVLoneStar commented Apr 29, 2021 via email

@cp2004 cp2004 changed the title [Bug] [Request] Refresh/reset button to push all status to WLED Apr 30, 2021
@cp2004 cp2004 added the request New feature or request label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants