Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry check for completed continuous replication incorrect #1495

Open
borrrden opened this issue Mar 29, 2018 · 2 comments
Open

Retry check for completed continuous replication incorrect #1495

borrrden opened this issue Mar 29, 2018 · 2 comments
Assignees
Labels

Comments

@borrrden
Copy link
Member

Reference

The goal here is to loop checking a condition until replication completes. That means that the following steps need to happen:

  1. Wait for idle
  2. Check condition
  3. If condition fulfilled, continue
  4. Else goto 1

However, in the snippet above the process is this

  1. Wait for idle
  2. Stop replication
  3. Check condition over and over again with delay

Since the replication is stopped, the condition will never recover

@raghusarangapani
Copy link
Contributor

raghusarangapani commented Mar 29, 2018

Moved the replication stop logic to the end. Check it out and let know if it fixes the issue.

@borrrden
Copy link
Member Author

That should do it, just make sure that there are no other places where you use similar logic.

@djpongh djpongh added the icebox label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants