{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":91447562,"defaultBranch":"master","name":"kv_engine","ownerLogin":"couchbase","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-05-16T10:49:39.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/605755?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1724969515.0","currentOid":""},"activityList":{"items":[{"before":"57b242f0e1bb0343eff6afbdcbb34c23280bca3b","after":"9385636620901e870104e77157611fcd80770c6e","ref":"refs/heads/master","pushedAt":"2024-09-21T09:01:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-62703: End backfilling (memory) streams which make no progress\n\nSimilar to disk backfill, track a position and monitor that it\nmoves within the configured duration.\n\nChange-Id: Ic8c05ca91fb12ca5774fdb678c2679533ef8edc1\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/214580\nReviewed-by: Trond Norbye \nTested-by: Jim Walker ","shortMessageHtmlLink":"MB-62703: End backfilling (memory) streams which make no progress"}},{"before":"9fb378fa234a579881f09561ea0b535a73b9e278","after":"57b242f0e1bb0343eff6afbdcbb34c23280bca3b","ref":"refs/heads/master","pushedAt":"2024-09-21T09:01:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-62703: End backfilling (disk) streams which make no progress\n\nA DCP stream which is backfilling can indefinitely hold disk resources\nif it hangs. This has been seen to happen and even though the connection\nowning the stream responds to DCP_NOOP messages. The server must check\nfor this condition and end the stream if no progress is made.\n\nScanContext is given an \"abstract\" Position type which allows the\nDCP backfill class to monitor progress of the scan and check the\ntime. No change of position within the configured time results the\nstream being ended with reason \"Slow\", releasing the disk resources.\n\nA new config parameter \"dcp_backfill_idle_limit_seconds\" controls how\nlong the server will tolerate a backfill with no progress. This\nparameter can be changed, but any new value only takes effect with\nscans started after the parameter is changed. The default is 120\nseconds which should be ample time to determine a client is faulty\nwithout causing too much damage.\n\nEphemeral buckets are addressed in the next commit.\n\nChange-Id: I23d050999ac601ff301da4fa3c64f9c75cc3c0ab\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/214579\nReviewed-by: Trond Norbye \nTested-by: Jim Walker ","shortMessageHtmlLink":"MB-62703: End backfilling (disk) streams which make no progress"}},{"before":"da4dcff2c18fe8e8a582c903cfa4eec1fbc95888","after":"9fb378fa234a579881f09561ea0b535a73b9e278","ref":"refs/heads/master","pushedAt":"2024-09-20T15:28:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-60438: Stream::setDead() returns void\n\nAll the existing implementations don't need to return any non-void\nvalue.\n\nChange-Id: I35f4c9c987e013252985ada1d2aa7968fa514799\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216409\nTested-by: Paolo Cocchi \nReviewed-by: Trond Norbye ","shortMessageHtmlLink":"MB-60438: Stream::setDead() returns void"}},{"before":"f6fd033a0364550e278b79b59f3ceafbd5690c3f","after":"da4dcff2c18fe8e8a582c903cfa4eec1fbc95888","ref":"refs/heads/master","pushedAt":"2024-09-20T15:28:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-60438: Avoid concurrent access on PassiveStream::unackedBytes\n\nBefore this change we used to handle stream's unacked bytes inline at\nstream close.\n\nThat approach originates a logical race on PassiveStream::unackedBytes\nbetween fronend thread (Stream::close() path) and backgorund thread\n(Stream::processUnackedBytes() path). MB-56275 and MB-60468 are example\nof bugs that we had to solve for handling properly that concurrent\naccess.\n\nSince when we removed the DCP Consumer Buffer in MB-31869, that code is\nmuch simpler. Plus, we can completely avoid any concurrent access to\nPassiveStream::unackedBytes and any possible data race on that.\n\nBy this patch Stream::close() doesn't process any pending unacked\nbytes. That is deferred to PassiveStream::dtor, where we know that any\nbackgorund processing on PassiveStream has already completed.\n\nChange-Id: I12fa80a0b09e3975e9f17e9027794f3692c216b7\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216405\nReviewed-by: Jim Walker \nTested-by: Build Bot ","shortMessageHtmlLink":"MB-60438: Avoid concurrent access on PassiveStream::unackedBytes"}},{"before":"6931e4905d27f8c76b39a081537618d478642d29","after":"f6fd033a0364550e278b79b59f3ceafbd5690c3f","ref":"refs/heads/master","pushedAt":"2024-09-20T14:15:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-62703: Rename seqnoScanCallback to scanCallback\n\nThis callback is used for both key and seqno index scans, the\nname is inaccurate.\n\nChange-Id: I547b5d1c7b160dce0046ce0d31c7123ece2fc788\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216389\nReviewed-by: Trond Norbye \nTested-by: Jim Walker ","shortMessageHtmlLink":"MB-62703: Rename seqnoScanCallback to scanCallback"}},{"before":"a00bbecd97f2302f4d87809430cee587b2c82be2","after":"6931e4905d27f8c76b39a081537618d478642d29","ref":"refs/heads/master","pushedAt":"2024-09-20T13:43:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-62250: Prepare to tell Magma to start/stop backup\n\nThis patch adds the logic for calling Magma::StartBackup and\nMagma::StopBackup when a vbucket changes to active.\n\nThis is implemented by calling the appropriate function after a vbstate\nflush, to ensure that newly started backup will see the vbucket in the\nexpected state.\n\nThis design requires a vbstate flush for the parameter change to\n'continuous_backup_enabled' to take effect.\n\nIn the following patch, a vbstate will be queued when the parameter\nchanges.\n\nChange-Id: I5827cde23a9d3153f997437000da40ea4285f14f\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216184\nTested-by: Vesko Karaganev \nReviewed-by: Paolo Cocchi \nReviewed-by: Trond Norbye ","shortMessageHtmlLink":"MB-62250: Prepare to tell Magma to start/stop backup"}},{"before":"a50d3e263e12b95b150dc96359bec3b245922165","after":"a00bbecd97f2302f4d87809430cee587b2c82be2","ref":"refs/heads/master","pushedAt":"2024-09-20T08:12:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"auditd: add 'sync_gateway' module and reserved event ID range\n\nThe 'sync_gateway_descriptor.json' file is a placeholder and is only used to reserve the audit event ID range listed by the 'startid' field in the 'module_descriptors.json' file.\n\nThe Sync Gateway team independently maintains audit event IDs within this range, outside of the Server's build process and does not use auditd.\n\nChange-Id: I53dc631b93f2755b8d0c1824584e5bb5cffd546e\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/209857\nReviewed-by: Trond Norbye \nTested-by: Trond Norbye ","shortMessageHtmlLink":"auditd: add 'sync_gateway' module and reserved event ID range"}},{"before":"9e86b5267b8e70a9cab0e08af91e354a4118cd77","after":"a50d3e263e12b95b150dc96359bec3b245922165","ref":"refs/heads/master","pushedAt":"2024-09-20T05:44:09.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'couchbase/cypher' into trunk\n\n* couchbase/cypher:\n MB-63275: Add --version to mctools\n\nChange-Id: I32cdab71931d9a386d51af5f796dcf519dbcc0c0","shortMessageHtmlLink":"Merge remote-tracking branch 'couchbase/cypher' into trunk"}},{"before":"d113f2776f36b452402c3736a799ac78212fc985","after":"9e86b5267b8e70a9cab0e08af91e354a4118cd77","ref":"refs/heads/master","pushedAt":"2024-09-19T18:38:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Update unmerged-commits.py with old branches\n\nChange-Id: If7a3f580485fd69ff6b217ae58f12fdc9b1462f3\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216233\nTested-by: Trond Norbye \nReviewed-by: Trond Norbye ","shortMessageHtmlLink":"Update unmerged-commits.py with old branches"}},{"before":"728410766e98767b0ad111f82b1ea69318b9f795","after":"d113f2776f36b452402c3736a799ac78212fc985","ref":"refs/heads/master","pushedAt":"2024-09-19T16:18:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-54274: Don't delete temp item immediately\n\nCurrent behavior:\n\n- A temp item is inserted in the HT if a GET is requested for a deleted\n key in a full-eviction bucket.\n- A bgfetch is scheduled & temp item is replaced with the actually\n delete value from disk when the bgfetch completes.\n- When the front-end thread retries the GET, the temp-item is\n immediately deleted.\n\nWhile this makes sense - it's sub-optimal when we have concurrent GET's\nfor the same deleted key.\n\nConsider the following scenario:\n\n1. Client-1 requests (GET) a deleted item in a full-eviction bucket.\n2. We create a temp-item (mark it temp_init) & queue a bg-fetch.\n3. Client-2 requests the same deleted item.\n4. We notice the temp-item in the hash-table & queue another bg-fetch.\n5. The bg-fetch completes, the front-end cookie for Client-1 is notified.\n6. A Get it issued again & the temp item is deleted.\n7. When the bg-fetch for client-2 completes it notices the temp-item is\n deleted & another bg-fetch is scheduled.\n\nIn the worst case we would have scheduled 3 bgfetches which could have\nbeen easily served with a single bgfetch.\n\nAn important question though is when & how will this temp item be\neventually removed?\n\nWe currently have a expiry pager scheduled every 10 mins & that will\neventually clean-up the temp-items.\n\nIn addition to the above cleanup, we have an additional guardrail to\nprevent unlimited growth of the temp items. A new configuration knob\n\"ht_temp_items_allowed_percent\" (default = 10%) is added which limits\nthe number of temp items allowed in the hashtable as a percentage of the\nHT size. The number of temp items allowed is updated on each HT when the\nnext HT resizer task runs.\n\nNote, it can happen so at a later point some items are deleted & the\ntemp items percentage could be greater than\n\"ht_temp_items_allowed_percent\".\n\nChange-Id: I945eb7945b5fd869ed1ed973f5c16b6f5293f9ab\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/214421\nReviewed-by: Dan Owen \nTested-by: Build Bot \nReviewed-by: Vesko Karaganev ","shortMessageHtmlLink":"MB-54274: Don't delete temp item immediately"}},{"before":"5f75240b32c88dc790bc7d31e0e8ad8d6d70fc39","after":"728410766e98767b0ad111f82b1ea69318b9f795","ref":"refs/heads/master","pushedAt":"2024-09-19T14:10:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"[jenkins_failures] Hack around the API and reduce resource use\n\nThis change implements a horrible hack around the Jenkins API to reduce\nresource usage and make the script run much faster (and hopefully less\nlikely to take down Jenkins).\n\nIt does so by using the tree= query parameter on the JSON REST API\nendpoint.\n\nBefore:\n\n Elapsed (wall clock) time (h:mm:ss or m:ss): 2:11.38\n Maximum resident set size (kbytes): 1346000\n\nAfter:\n\n Elapsed (wall clock) time (h:mm:ss or m:ss): 0:14.98\n Maximum resident set size (kbytes): 42096\n\nChange-Id: If6b47928677e50718bddd08f9c18142a8fff9d60\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216353\nTested-by: Vesko Karaganev \nReviewed-by: Pavlos Georgiou ","shortMessageHtmlLink":"[jenkins_failures] Hack around the API and reduce resource use"}},{"before":"33fdaea4d5034c498da5c4a240086c1997c0c680","after":"5f75240b32c88dc790bc7d31e0e8ad8d6d70fc39","ref":"refs/heads/master","pushedAt":"2024-09-19T11:14:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-60861: Use JSON logging for ActiveStream\n\n INFO Creating stream {\"bucket\":\"default\",\"dcp\":\"Producer\",\"stream\":\"test_producer->test_consumer\",\"vb\":\"vb:0\",\"takeover\":false,\"start_seqno\":0,\"end_seqno\":18446744073709551615,\"requested_end_seqno\":18446744073709551615,\"flags\":\"\\\"None\\\"\",\"snapshot\":[0,18446744073709551615],\"filter\":\"filter:{legacy, size:1}\"}\n INFO ActiveStream::scheduleBackfill_UNLOCKED register cursor {\"bucket\":\"default\",\"dcp\":\"Producer\",\"stream\":\"test_producer->test_consumer\",\"vb\":\"vb:0\",\"name\":\"test_producer->test_consumer\",\"cursor_req_seqno\":0,\"try_backfill\":false,\"op\":\"empty\",\"seqno\":1,\"next_seqno\":1}\n\nChange-Id: Ie32e2791b0c12d07f483209eb93dd3edd4db2cd6\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216258\nTested-by: Build Bot \nReviewed-by: Jim Walker ","shortMessageHtmlLink":"MB-60861: Use JSON logging for ActiveStream"}},{"before":"f42c6e8787d8fb7ee7b2b6693873f3cda72e0e1b","after":"33fdaea4d5034c498da5c4a240086c1997c0c680","ref":"refs/heads/master","pushedAt":"2024-09-19T10:35:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"[jenkins_failures] Add missing CV and improve CLI usage\n\nAdded linux-aarch64 and allowed the parse mode to be used without\nneeding to specify username and password (previously required positional\nargs, now optional).\n\nChange-Id: Ifd36d1a563af585c955fced5221ae24b122c5508\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216290\nTested-by: Build Bot \nReviewed-by: Pavlos Georgiou ","shortMessageHtmlLink":"[jenkins_failures] Add missing CV and improve CLI usage"}},{"before":"0fc8596ad0d598c048b5a9343b8783b40966ff3a","after":"290143856e0b76207d3e3557a6f0a30b0570c55f","ref":"refs/heads/trinity","pushedAt":"2024-09-19T09:45:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"[BP] MB-60382: Fix intermittent GetAllKeys Failure\n\nWe should wait till all upserts have persisted before initiating a\nGetAllKeys command. The test was seen to fail when a document was\nstill pending and has not yet persisted. AllKeysCallback skips\ndurability-prepared keys, and on machines where the flusher is slow,\nthose keys are not returned.\n\nThis patch retrieves the last seqno and persists all seqnos up\nto and including this one, ensuring that no key remains in the\nprepared state.\n\nChange-Id: I479480f5c56444658b3d89f3f7423bf00bd96a6d\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/211798\nTested-by: Mohammad Zaeem \nWell-Formed: Restriction Checker\nReviewed-by: Jim Walker ","shortMessageHtmlLink":"[BP] MB-60382: Fix intermittent GetAllKeys Failure"}},{"before":"369aa4412847334fbe4ddd104e161b68ee935bb9","after":"f42c6e8787d8fb7ee7b2b6693873f3cda72e0e1b","ref":"refs/heads/master","pushedAt":"2024-09-19T08:34:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-63521: Log for connections stuck in shutdown\n\nAs part of accepting new connections try to check if there is\nconnections \"stuck\" in shutdown. Any connection currently closing\nand stuck for more than 10 seconds gets logged (once logged it\nwon't logged again for the next 10 seconds to avoid flooding the\nlogs).\n\nChange-Id: I21ea8d5946e07c96550d4f67943ed9889921a96c\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216086\nTested-by: Build Bot \nReviewed-by: Vesko Karaganev ","shortMessageHtmlLink":"MB-63521: Log for connections stuck in shutdown"}},{"before":"0a1aa68f87c47b2a0fedf3ba554df4c7a9c86a7f","after":"369aa4412847334fbe4ddd104e161b68ee935bb9","ref":"refs/heads/master","pushedAt":"2024-09-18T12:39:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-62496: Add flatbuffer schema for backup metadata\n\nAnd update the test code.\n\nChange-Id: I751f0ad73d6e95ac806681aff9149ad36740d470\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216098\nTested-by: Build Bot \nReviewed-by: Jim Walker ","shortMessageHtmlLink":"MB-62496: Add flatbuffer schema for backup metadata"}},{"before":"6ab11ff25cdd285356e1cead602a370d7f758178","after":"0a1aa68f87c47b2a0fedf3ba554df4c7a9c86a7f","ref":"refs/heads/master","pushedAt":"2024-09-18T12:28:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-62178 Refactor usage of Magma::CompactKVStore to drop DEKs\n\nMagma's CompactKVStore API now supports doing all types of compactions\nbased on the arguments passed:\n- full compaction\n- range compaction\n- partial compaction to drop given DEKs\n- range compaction + partial compaction to drop given DEKs\n\nLinked magma change:\nhttps://review.couchbase.org/c/magma/+/216281\n\nChange-Id: I95a0a97076d49af4d9833d04d5c32f1a441265f1\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216280\nReviewed-by: Jim Walker \nTested-by: Build Bot ","shortMessageHtmlLink":"MB-62178 Refactor usage of Magma::CompactKVStore to drop DEKs"}},{"before":"6d9c5c0e78941ec01ba3480010adb3f40d2fce89","after":"0fc8596ad0d598c048b5a9343b8783b40966ff3a","ref":"refs/heads/trinity","pushedAt":"2024-09-18T12:12:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-63196: Fix vattr SystemXattr permission\n\nUpdate permission check to collection level.\n\nChange-Id: I023af35240a02294089f03ee14997bce7c2ab88f\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/215909\nWell-Formed: Restriction Checker\nTested-by: Build Bot \nReviewed-by: Jim Walker ","shortMessageHtmlLink":"MB-63196: Fix vattr SystemXattr permission"}},{"before":"92c6d47af8ea354e11343b3394e3df1919dd5b26","after":"6ab11ff25cdd285356e1cead602a370d7f758178","ref":"refs/heads/master","pushedAt":"2024-09-18T11:56:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-62496: Add onContinuousBackupCallback to MagmaKVStore\n\nFor now, we only have a dummy implementation, which serialises to JSON,\ninstead of flatbuffer, and is only called from our tests.\n\nChange-Id: I9035dc73b038555f9deac7a6ffb9816dfe9049e4\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/215587\nReviewed-by: Paolo Cocchi \nTested-by: Build Bot ","shortMessageHtmlLink":"MB-62496: Add onContinuousBackupCallback to MagmaKVStore"}},{"before":"ef511fc4b1c84e2457452698ec1a2486cefe7d01","after":"d3a8d831c56f190078dec4e25b5f5a9b72f5a149","ref":"refs/heads/cypher","pushedAt":"2024-09-17T05:21:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'couchbase/trinity' into cypher\n\n* couchbase/trinity:\n MB-63275: Add --version to mctools\n\nChange-Id: Ia367ec033f044fd89a30bb0605a53c473d7e94e8","shortMessageHtmlLink":"Merge remote-tracking branch 'couchbase/trinity' into cypher"}},{"before":"6e1c21cc0611fdd860765db01baac49298dc1eb0","after":"6d9c5c0e78941ec01ba3480010adb3f40d2fce89","ref":"refs/heads/trinity","pushedAt":"2024-09-16T18:57:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-63275: Add --version to mctools\n\nTo print out:\n\n Couchbase Server PRODUCT_VERSION\n\n(where PRODUCT_VERSION is whatever the build is configured with)\n\nChange-Id: I29ab424953c19b9a3aaa01a4e4f25e6e1f9601da\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/214941\nTested-by: Build Bot \nReviewed-by: Paolo Cocchi \nWell-Formed: Restriction Checker","shortMessageHtmlLink":"MB-63275: Add --version to mctools"}},{"before":"cce421866741822bb9d3ba7335277a8ec74d9d5c","after":"92c6d47af8ea354e11343b3394e3df1919dd5b26","ref":"refs/heads/master","pushedAt":"2024-09-16T12:38:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Add links to related RFCs for JWTs\n\nChange-Id: Id977dd2b47709e462b2b014fb2bc3028a35c53ec\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216250\nTested-by: Trond Norbye \nReviewed-by: Vesko Karaganev ","shortMessageHtmlLink":"Add links to related RFCs for JWTs"}},{"before":"17e5b1cb1ecbc76e2cda19fe9c4672ca33c8b538","after":"cce421866741822bb9d3ba7335277a8ec74d9d5c","ref":"refs/heads/master","pushedAt":"2024-09-16T09:54:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-60861: Use JSON logging for HELO\n\n INFO HELO {\"conn_id\":24,\"client\":{\"a\":\"MemcachedConnection\"},\"features\":[],\"description\":{\"peer\":{\"ip\":\"127.0.0.1\",\"port\":65465},\"socket\":{\"ip\":\"127.0.0.1\",\"port\":65462},\"user\":null}}\n\nChange-Id: Icaf0e945a70fde4b44a2374087bda93a1546795f\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/215695\nReviewed-by: Mohammad Zaeem \nTested-by: Build Bot \nReviewed-by: Trond Norbye ","shortMessageHtmlLink":"MB-60861: Use JSON logging for HELO"}},{"before":"9d22fab8ef7b73d96985017e1624d00062418851","after":"17e5b1cb1ecbc76e2cda19fe9c4672ca33c8b538","ref":"refs/heads/master","pushedAt":"2024-09-13T10:28:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-62178: Add stats to get encryption key ids in use (magma)\n\nAdd support for requesting encryption keys in use for a bucket\nfor magma.\n\nChange-Id: Ic1193418f203b0613f7dd0d2fa5002177af4b363\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/215877\nReviewed-by: Rohan Suri \nTested-by: Trond Norbye \nReviewed-by: Jim Walker ","shortMessageHtmlLink":"MB-62178: Add stats to get encryption key ids in use (magma)"}},{"before":"18bdc52cccb42e3204e52435044539570d40854c","after":"9d22fab8ef7b73d96985017e1624d00062418851","ref":"refs/heads/master","pushedAt":"2024-09-13T09:53:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-63464: Add logging to the lifetime of connections\n\nIncrease the logging of connections to the system port to\ninclude when the socket gets accepted from accept() and\nwhen the client disconnect (including if it is connreset,\nunexpected EOF or just EOF).\n\n INFO Accepting client on system interface {\"conn_id\":48,\"peer\":{\"ip\":\"127.0.0.1\",\"port\":63781}}\n INFO Delete connection connected to system port {\"conn_id\":48,\"reason\":\"Client closed connection: EOF\"}\n\nChange-Id: I0c6e85b3ad45372bd69c28978b821a687dad82ef\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216157\nReviewed-by: Vesko Karaganev \nTested-by: Trond Norbye ","shortMessageHtmlLink":"MB-63464: Add logging to the lifetime of connections"}},{"before":"0d9de1a36e47b9ba7c34d0d458038656af06d4c7","after":"18bdc52cccb42e3204e52435044539570d40854c","ref":"refs/heads/master","pushedAt":"2024-09-13T09:11:48.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'origin/cypher'\n\n* origin/cypher:\n MB-63171: Add tools to standalone admin_tools package\n MB-63472 Use the connection id as the key for conn stats\n\nChange-Id: I493fc0c04c343508e4fdce4e7c2a5238d1ba8eea","shortMessageHtmlLink":"Merge remote-tracking branch 'origin/cypher'"}},{"before":"acecab8650a30f7e23213138ce6e27479b4e2287","after":"0d9de1a36e47b9ba7c34d0d458038656af06d4c7","ref":"refs/heads/master","pushedAt":"2024-09-12T19:44:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Add MEMCACHED_DEBUG_STOP to attach debugger in cluster_run easily\n\nMakes it easier to attach a debugger to memcached.\n\nChange-Id: I0503877202375d2212b80faebecc3fd5ac65765f\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/215892\nTested-by: Vesko Karaganev \nReviewed-by: Trond Norbye ","shortMessageHtmlLink":"Add MEMCACHED_DEBUG_STOP to attach debugger in cluster_run easily"}},{"before":"4396a7bbe9850c6fe2811d3f308b14c386639837","after":"acecab8650a30f7e23213138ce6e27479b4e2287","ref":"refs/heads/master","pushedAt":"2024-09-12T19:38:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-62178: Add support for migrating off keys in magma\n\nPass the list of obsolete keys down to magma as part of\ncompaction.\n\nNOTE: The implementation in magma may not be intuitive to\nthe caller as when a list of keys is provided it use a\ndifferent API in magma which *only* considers any segments\nusing one of the keys in the provided.\n\nChange-Id: Iac9ce4db0aee5c6f753cfcf56e48c04c213f3bc3\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/216047\nReviewed-by: Jim Walker \nTested-by: Build Bot ","shortMessageHtmlLink":"MB-62178: Add support for migrating off keys in magma"}},{"before":"999626c19f132c60f116392d71a4fca3fdf96cbb","after":"4396a7bbe9850c6fe2811d3f308b14c386639837","ref":"refs/heads/master","pushedAt":"2024-09-12T14:18:43.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"Merge \"Merge 'couchbase/cypher' into 'master'\"","shortMessageHtmlLink":"Merge \"Merge 'couchbase/cypher' into 'master'\""}},{"before":"f510541bd16d3950495116dd456c060480c9ee56","after":"999626c19f132c60f116392d71a4fca3fdf96cbb","ref":"refs/heads/master","pushedAt":"2024-09-12T13:51:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ns-codereview","name":null,"path":"/ns-codereview","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/318262?s=80&v=4"},"commit":{"message":"MB-63262: Re-enable magma per document compression\n\nMagma per document compression will now be enabled by default.\n\nMagma per document compression was disabled due to previous bugs.\nSince patch https://review.couchbase.org/c/magma/+/191084 resolves these\nbugs, we can now re-enable per-doc compression.\n\n- Add parameterized tests over per doc compression\n- Fix various tests to handle magma per doc compression\n- Fix parameterized collection tests\n\nChange-Id: Id545e8b4546700849d6aa706508dc9b1ea274b21\nReviewed-on: https://review.couchbase.org/c/kv_engine/+/215907\nTested-by: Build Bot \nReviewed-by: Jim Walker ","shortMessageHtmlLink":"MB-63262: Re-enable magma per document compression"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMVQwOTowMTo0MC4wMDAwMDBazwAAAAS8nxqB","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yMVQwOTowMTo0MC4wMDAwMDBazwAAAAS8nxqB","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xMlQxMzo1MToxNy4wMDAwMDBazwAAAAS0cz30"}},"title":"Activity ยท couchbase/kv_engine"}