Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is UseIPAsName really used? #46

Open
kaiyou opened this issue May 21, 2020 · 1 comment
Open

Is UseIPAsName really used? #46

kaiyou opened this issue May 21, 2020 · 1 comment
Labels
techdebt This may hamper further development

Comments

@kaiyou
Copy link
Contributor

kaiyou commented May 21, 2020

This setting is not documented in README.md and explicitely marked as a testing setting in config.go. However, I cannot foresee a testing use case for it, especially when e2e.sh makes no use of it for automated e2e testing.

Is it really used? And if not, should we get rid of it?
@costela
Copy link
Owner

costela commented May 22, 2020

It was added to ease local testing on the same machine without having to set up docker+wireguard-go (it predates the e2e tests). It can probably be removed since it's now pretty easy to start docker containers with tests/Dockerfile.

@costela costela added the techdebt This may hamper further development label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
techdebt This may hamper further development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@costela @kaiyou