Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to polarization ASAD method #275

Open
eneights opened this issue Dec 14, 2024 · 0 comments
Open

Changes to polarization ASAD method #275

eneights opened this issue Dec 14, 2024 · 0 comments
Assignees

Comments

@eneights
Copy link
Contributor

Some changes suggested by @israelmcmc based on PR #240:

  • Replace calculate_uncertainties() with sqrt(counts) and histpy's bin_error
  • Store ASADs as histpy Histogram objects
  • Exclude errors in response from error propagation
  • Move calculate_azimuthal_scattering_angle() to PolarizationAngle class
  • Make it possible for user to initialize PolarizationASAD object and immediately run fit()
  • Run profiler and optimize code (currently, use project() just to get number of bins, use for loops for operations that can be parallelized, and repeat operation within a loop that could be cached)
  • Replace fit to constant() function with np.mean()
  • Don't generate plots by default
  • Use logging instead of print statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant