Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update orientation file in 511keV-DC2-ScAtt-DataReduction notebook #266

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

augustus-thomas
Copy link

Closes #265

I am not sure how you change the top line to include the newest update hash and date.

@ckarwin
Copy link
Contributor

ckarwin commented Nov 12, 2024

Thanks again. This is very minor change and can probably be merged, but I would request @hirokiyoneda to review this, since he wrote the tutorial.

@hiyoneda
Copy link
Contributor

@augustus-thomas Thanks for this. All of the changes are 20280301_3_month.ori -> 20280301_3_month_with_orbital_info.ori, right? Then, it can be merged quickly. Actually, it is also used in docs/tutorials/image_deconvolution/Crab/ScAttBinning/Crab-DC2-ScAtt-DataReduction.ipynb, so I am happy if you can update it as well.

For the top line, you can replace it with when you run through the notebook. The hash is the same as the top one that you can get git log.

@ckarwin Do you plan to update the orientation file for mini DC2? Currently, there is an imaging notebook for GRB data in the mini DC2. If there isn't such a plan, the notebook for mini DC2 will be deleted at this PR.

@ckarwin
Copy link
Contributor

ckarwin commented Nov 13, 2024

@hiyoneda The ori file for mini DC2 should be the same as the main DC2. It looks like in the imaging notebook, you use just the first 2 hrs of the ori file. I think it's up to you if you wan to keep this notebook. If you decide to keep it, you would just need to remove times from the updated DC2 ori file to make it for the same 2 hr period. Does that work for you?

@hiyoneda
Copy link
Contributor

@ckarwin @saurabhmittal23 I checked it, but it is probably not like this. The mini DC2 orientation file is from 1835478000.0 to 1835485200.0, but the DC2 file starts from 1835487300.0.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.39%. Comparing base (f71e55d) to head (8c73aab).

@ckarwin
Copy link
Contributor

ckarwin commented Nov 14, 2024

@hiyoneda Ok, I assumed they were the same, but I guess not. I'm not sure why the times are different, but it's not a big deal. Do you think we should keep this imaging tutorial from mini-DC2? If so, I can upload the ori file with orbital info.

@hiyoneda
Copy link
Contributor

Yeah, let's remove this tutorial from mini DC2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpaceCraftFile refactor for orbital info breaks 511keV-DC2-ScAtt-DataReduction notebook
3 participants