-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update orientation file in 511keV-DC2-ScAtt-DataReduction notebook #266
base: develop
Are you sure you want to change the base?
Conversation
Thanks again. This is very minor change and can probably be merged, but I would request @hirokiyoneda to review this, since he wrote the tutorial. |
@augustus-thomas Thanks for this. All of the changes are For the top line, you can replace it with when you run through the notebook. The hash is the same as the top one that you can get @ckarwin Do you plan to update the orientation file for mini DC2? Currently, there is an imaging notebook for GRB data in the mini DC2. If there isn't such a plan, the notebook for mini DC2 will be deleted at this PR. |
@hiyoneda The ori file for mini DC2 should be the same as the main DC2. It looks like in the imaging notebook, you use just the first 2 hrs of the ori file. I think it's up to you if you wan to keep this notebook. If you decide to keep it, you would just need to remove times from the updated DC2 ori file to make it for the same 2 hr period. Does that work for you? |
@ckarwin @saurabhmittal23 I checked it, but it is probably not like this. The mini DC2 orientation file is from 1835478000.0 to 1835485200.0, but the DC2 file starts from 1835487300.0. |
@hiyoneda Ok, I assumed they were the same, but I guess not. I'm not sure why the times are different, but it's not a big deal. Do you think we should keep this imaging tutorial from mini-DC2? If so, I can upload the ori file with orbital info. |
Yeah, let's remove this tutorial from mini DC2. |
Closes #265
I am not sure how you change the top line to include the newest update hash and date.