From d5bdbfacb4d2c013f7bebabc6c95a118dc1e9fe1 Mon Sep 17 00:00:00 2001 From: Felix L <50841330+Felix-El@users.noreply.github.com> Date: Wed, 3 Apr 2024 12:00:15 +0200 Subject: [PATCH] corrosion_import_crate: Fix PROFILE argument in combination with CRATES (#496) Do not forward the PROFILE argument from `corrosion_import_crate` to `_generator_add_cargo_targets`. The PROFILE argument is forwarded via a target property set during `corrosion_import_crate`. The remaining argument forwarding can cause issues when combined with a multi-value-argument, such as `CRATES`. --------- Co-authored-by: Jonathan Schwender --- cmake/Corrosion.cmake | 2 -- 1 file changed, 2 deletions(-) diff --git a/cmake/Corrosion.cmake b/cmake/Corrosion.cmake index 590f0191..e47efe45 100644 --- a/cmake/Corrosion.cmake +++ b/cmake/Corrosion.cmake @@ -894,7 +894,6 @@ function(corrosion_import_crate) _corrosion_option_passthrough_helper(FROZEN COR frozen) _corrosion_arg_passthrough_helper(CRATES COR crate_allowlist) _corrosion_arg_passthrough_helper(CRATE_TYPES COR crate_types) - _corrosion_arg_passthrough_helper(PROFILE COR cargo_profile) if(COR_PROFILE) if(Rust_VERSION VERSION_LESS 1.57.0) @@ -934,7 +933,6 @@ function(corrosion_import_crate) imported_crates ${crate_allowlist} ${crate_types} - ${cargo_profile} ${no_linker_override} )