cmd-create-legacy-oscontainer: rename cmd-upload-oscontainer

Author: jmarrero

cmd/coreos-assembler.go

@@ -13,7 +13,7 @@ import (
 
 // commands we'd expect to use in the local dev path
 var buildCommands = []string{"init", "fetch", "build", "run", "prune", "clean", "list"}
-var advancedBuildCommands = []string{"buildfetch", "buildupload", "oc-adm-release", "push-container", "upload-oscontainer", "buildextend-extensions"}
+var advancedBuildCommands = []string{"buildfetch", "buildupload", "oc-adm-release", "push-container", "create-legacy-oscontainer", "buildextend-extensions"}
 var buildextendCommands = []string{"aliyun", "aws", "azure", "digitalocean", "exoscale", "gcp", "ibmcloud", "kubevirt", "live", "metal", "metal4k", "nutanix", "openstack", "qemu", "secex", "virtualbox", "vmware", "vultr"}
 var utilityCommands = []string{"aws-replicate", "build-extensions-container", "compress", "generate-hashlist", "koji-upload", "kola", "push-container-manifest", "remote-build-container", "remote-prune", "remote-session", "sign", "update-variant"}
 var otherCommands = []string{"shell", "meta"}

docs/cosa.md

@@ -71,4 +71,4 @@ Those less commonly used commands are listed here:
 | [supermin-shell](https://github.com/coreos/coreos-assembler/blob/main/src/cmd-supermin-shell) | Get a supermin shell
 | [tag](https://github.com/coreos/coreos-assembler/blob/main/src/cmd-tag) | Operate on the tags in `builds.json`
 | [test-coreos-installer](https://github.com/coreos/coreos-assembler/blob/main/src/cmd-test-coreos-installer) | Automate an end-to-end run of coreos-installer with the metal image
-| [upload-oscontainer](https://github.com/coreos/coreos-assembler/blob/main/src/cmd-upload-oscontainer) | Upload an oscontainer (historical wrapper for `cosa oscontainer`)
+| [create-legacy-oscontainer](https://github.com/coreos/coreos-assembler/blob/main/src/cmd-create-legacy-oscontainer) | Create an oscontainer oci-archive (historical wrapper for `cosa oscontainer`)

gangplank/internal/ocp/worker.go

@@ -394,7 +394,7 @@ func pushOstreeToRegistry(ctx ClusterContext, push *spec.Registry, build *cosa.B
 
 	// pushArgs invokes cosa upload code which creates a named tag
 	pushArgs := []string{
-		"/usr/bin/coreos-assembler", "upload-oscontainer",
+		"/usr/bin/coreos-assembler", "create-legacy-oscontainer",
 		fmt.Sprintf("--name=%s", pushPath),
 	}
 	// copy the pushed image to the expected tag

src/cmd-upload-oscontainer renamed to src/cmd-create-legacy-oscontainer

@@ -1,6 +1,6 @@
 #!/usr/bin/python3 -u
 # Upload the container to a registry.  Note this
-# is distinct from `upload-oscontainer` which
+# is distinct from `create-legacy-oscontainer` which
 # only applies to (hopefully soon only older)
 # versions of RHCOS but not FCOS.