Package links with plus character result in broken redirect

[palmskog]

Generated links to packages with versions that have a + character in them give a redirect error. For example, Firefox gives the following error:

The page isn’t redirecting properly

Examples of package links that are broken like this:

• https://rocq-prover.org/p/coq-equations/1.3.1%2B8.20 (version 1.3.1+8.20)
• https://rocq-prover.org/p/coq-autosubst-ocaml/1.1%2B8.20 (version 1.1+8.20)

[mattam82]

After a cursory look I couldn't find the bug yet... Needs to be investigated some more. Probably also affects ocaml.org

[cuihtlauac]

ocaml.org doesn't seem to be affected:

https://ocaml.org/p/mccs/1.1%2B9
https://ocaml.org/p/libtorch/2.2.1%2Blinux-x86_64

Remember that ocaml.org doesn't manage to produce documentation for all opam packages & versions. This test has false negative results. Could it be the case on your side, too?

[Zimmi48]

Now, this bug has become more serious because it affects links for the Rocq 9.0+rc1 release as well:

• https://rocq-prover.org/doc/V9.0%2Brc1/refman/index.html
• https://rocq-prover.org/doc/V9.0%2Brc1/stdlib/index.html
• https://rocq-prover.org/releases/9.0%2Brc1

The last one in particular is a link that is shown prominently on the front page.

[Zimmi48]

Apparently, it was an issue with the reverse proxy (outside the code of rocq-prover.org) which has been fixed: https://coq.zulipchat.com/#narrow/channel/476133-rocq-prover.2Eorg/topic/9.2E0.2Brc1.20links.20.2F.20display/near/495999454