Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI minimization needs to be adapted to smaller artifacts #332

Open
JasonGross opened this issue Dec 16, 2024 · 1 comment
Open

CI minimization needs to be adapted to smaller artifacts #332

JasonGross opened this issue Dec 16, 2024 · 1 comment

Comments

@JasonGross
Copy link
Member

@JasonGross @Zimmi48 not sure if the minimizer needs to be changed for this

Sorry, I missed this. Yes, this breaks the minimizer setup (as in, it will probably rebuild all the dependent CI developments from scratch in order to run the minimizer, and be quite slow). The checks tab summary (e.g., this) for each job will now need to report all dependent artifacts that are downloaded for each job, and we need to parse this information a la

bot/src/actions.ml

Lines 911 to 917 in 1d7655f

if
string_match
~regexp:
"This job ran on the Docker image `\\([^`]+\\)`, depended on the \
build job `\\([^`]+\\)` with OCaml `\\([^`]+\\)`.\n\n"
summary
then
and insert it when it exists at

bot/src/actions.ml

Lines 960 to 961 in 1d7655f

; failing_urls= head_build_url ^ " " ^ head_job_url
; passing_urls= base_build_url ^ " " ^ base_job_url } )
. @Zimmi48 could you take care of this?

Originally posted by @JasonGross in coq/coq#19926 (comment)

@ticket-tagger ticket-tagger bot added the bug Something isn't working label Dec 16, 2024
@JasonGross JasonGross added bug minimizer and removed bug Something isn't working labels Dec 16, 2024
@JasonGross
Copy link
Member Author

Probably the format we want is something like "This job ran on the Docker image ..., depended on the build job ... with OCaml ..., and on the non-build jobs ..." and then we can parse out the last bit as an optional string, split on , , strip backticks, partition_map (or try Some (map (fun job -> Option.get (extract_artifact_url job summary)) jobs) with Invalid_argument -> None).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant