Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI badge in README template #3

Merged
merged 1 commit into from
Nov 26, 2019
Merged

CircleCI badge in README template #3

merged 1 commit into from
Nov 26, 2019

Conversation

liyishuai
Copy link
Member

@liyishuai liyishuai commented Nov 22, 2019

Related issue: #1

Motivation

CircleCI is getting popular in Coq projects in and outside the community:

Todo

  • CircleCI configuration template
    As suggested in CircleCI template #1 (comment), we could propose a template to CircleCI directly, since the purpose of CircleCI is to allow developers customize testing scripts conveniently.

Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the only difference between the current README and the new README is only the CircleCI badge, then it should not be duplicated. Instead, you can use some mustache logic to decide which badge to put in the README template.

@liyishuai liyishuai marked this pull request as ready for review November 22, 2019 18:56
@liyishuai liyishuai changed the title WIP: CircleCI template CircleCI badge in README template Nov 22, 2019
@liyishuai liyishuai requested a review from Zimmi48 November 26, 2019 01:18
@Zimmi48
Copy link
Member

Zimmi48 commented Nov 26, 2019

@liyishuai The change of title sounds like you propose to merge this first step (this is OK with me). But in this case, the PR description should not say that it Resolves #1.

@liyishuai liyishuai merged commit 91e02ee into master Nov 26, 2019
@liyishuai liyishuai deleted the circleci branch November 26, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants