Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Gitlab and others #113

Open
ana-borges opened this issue Feb 15, 2022 · 4 comments
Open

Support for Gitlab and others #113

ana-borges opened this issue Feb 15, 2022 · 4 comments

Comments

@ana-borges
Copy link

Currently the templates assume that the code is hosted on Github. For example, many links are hard-coded as github.com/....

It would be nice to be a little more permissive and include other hosts, such as Gitlab. It's not as simple as updating the links because the CI scripts also need to be updated, but it's also not that different.

I have a fork of this repo that assumes the code is hosted on Gitlab, which could be used as inspiration.

@Zimmi48
Copy link
Member

Zimmi48 commented Feb 17, 2022

Can we assume that if people are hosting code on GitLab, they will use GitLab CI? We could then add a gitlab: true field for noting that GitLab is used and pipeline: true (like you did) to generate the CI configuration. We could also consider making the use of pipeline: true possible even when gitlab: true is not set (for people who want to mirror on GitLab to get GitLab CI with a GitHub repo).

I guess we should also support GitLab instances beyond GitLab.com, shouldn't we?

@ana-borges
Copy link
Author

Perhaps having a variable for the url of the host would work? But it might not be that simple if the urls change more than just the substring before .com. Essentially I'm afraid that supporting other hosts or instances would need to be done on a case-by-case basis instead of in a fully general way.

@Zimmi48
Copy link
Member

Zimmi48 commented Feb 17, 2022

I was not talking about being more general than GitLab + GitHub. But all GitLab instances work the same, you only need to know the base domain name.

@thewalker77
Copy link

+1 need for gitlab in particular.

All the generated files have github urls hardcoded which will require a bit of manual patching.

And yes it is very good assumption to assume gitlab + gitlab CI ... it is actually my motivation so that I can have self hosted, fully controlled CI instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants