Skip to content

Commit 5d81eab

Browse files
authored
vine: use taskid to name library log file (#4030)
1 parent 28462b2 commit 5d81eab

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

taskvine/src/manager/vine_manager.c

+1-4
Original file line numberDiff line numberDiff line change
@@ -3921,7 +3921,6 @@ struct vine_manager *vine_ssl_create(int port, const char *key, const char *cert
39213921
cctools_uuid_t local_uuid;
39223922
cctools_uuid_create(&local_uuid);
39233923
q->uuid = strdup(local_uuid.str);
3924-
q->duplicated_libraries = 0;
39253924

39263925
q->next_task_id = 1;
39273926
q->fixed_location_in_queue = 0;
@@ -4723,8 +4722,6 @@ struct vine_task *send_library_to_worker(struct vine_manager *q, struct vine_wor
47234722
if (!check_worker_against_task(q, w, original)) {
47244723
return 0;
47254724
}
4726-
/* Track the number of duplicated libraries */
4727-
q->duplicated_libraries += 1;
47284725

47294726
/* Duplicate the original task */
47304727
struct vine_task *t = vine_task_copy(original);
@@ -4736,7 +4733,7 @@ struct vine_task *send_library_to_worker(struct vine_manager *q, struct vine_wor
47364733
/* If watch-library-logfiles is tuned, watch the output file of every duplicated library instance */
47374734
if (q->watch_library_logfiles) {
47384735
char *remote_stdout_filename = string_format(".taskvine.stdout");
4739-
char *local_library_log_filename = string_format("library-%d.debug.log", q->duplicated_libraries);
4736+
char *local_library_log_filename = string_format("library-task-%d.log", t->task_id);
47404737
t->library_log_path = vine_get_path_library_log(q, local_library_log_filename);
47414738

47424739
struct vine_file *library_local_stdout_file = vine_declare_file(q, t->library_log_path, VINE_CACHE_LEVEL_TASK, 0);

taskvine/src/manager/vine_manager.h

-1
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ struct vine_manager {
134134
/* Internal state modified by the manager */
135135

136136
int next_task_id; /* Next integer task_id to be assigned to a created task. */
137-
int duplicated_libraries; /* The number of duplicated libraries */
138137
int fixed_location_in_queue; /* Number of fixed location tasks currently being managed */
139138
int num_tasks_left; /* Optional: Number of tasks remaining, if given by user. @ref vine_set_num_tasks */
140139
int busy_waiting_flag; /* Set internally in main loop if no messages were processed -> wait longer. */

0 commit comments

Comments
 (0)