Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre & post deployment command details to docs #11

Open
andrasbacsai opened this issue Jun 6, 2024 — with Linear · 1 comment
Open

Add pre & post deployment command details to docs #11

andrasbacsai opened this issue Jun 6, 2024 — with Linear · 1 comment

Comments

Copy link
Member

  • Pre-deployment commands (they are simple)
  • Post-deployment commands: They could fail -> deployment will fail -> app won't be rolled back.
@andrasbacsai andrasbacsai self-assigned this Jun 6, 2024
@tonven
Copy link

tonven commented Jun 20, 2024

Hi. I have a question regarding pre & post deployment command. I have a command to run database migration script from nextjs app on my running supabase instance. The problem comes to choose which command I need to use. I thought that logically I need to use predeployment script. So it should create a new container, run migrations from it, and then, if there is no errors, deploy it. But as I understood, predeployment script is executed on existing container(correct me if I am wrong).
Because of this I need to run migration as a part of postdeployment command. But from your comment it will mean, that if migrations fail, it will still deploy a new container. Is this correct? Thank you for great product :)

@peaklabs-dev peaklabs-dev transferred this issue from coollabsio/coolify Sep 13, 2024
@andrasbacsai andrasbacsai removed their assignment Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants