Epsilon: Currency conversion (prebid#3199)

johnwier · web-flow · commit 2a5a0144943c · 2024-06-19T13:30:21.000+02:00
diff --git a/src/main/java/org/prebid/server/bidder/epsilon/EpsilonBidder.java b/src/main/java/org/prebid/server/bidder/epsilon/EpsilonBidder.java
@@ -18,6 +18,7 @@
 import org.prebid.server.bidder.model.BidderError;
 import org.prebid.server.bidder.model.HttpRequest;
 import org.prebid.server.bidder.model.Result;
+import org.prebid.server.currency.CurrencyConversionService;
 import org.prebid.server.exception.PreBidException;
 import org.prebid.server.json.DecodeException;
 import org.prebid.server.json.JacksonMapper;
@@ -39,6 +40,10 @@
 
 public class EpsilonBidder implements Bidder<BidRequest> {
 
+    private static final String BIDDER_CURRENCY = "USD";
+
+    private final CurrencyConversionService currencyConversionService;
+
     private static final TypeReference<ExtPrebid<?, ExtImpEpsilon>> EPSILON_EXT_TYPE_REFERENCE =
             new TypeReference<>() {
             };
@@ -59,10 +64,14 @@ public class EpsilonBidder implements Bidder<BidRequest> {
     private final boolean generateBidId;
     private final JacksonMapper mapper;
 
-    public EpsilonBidder(String endpointUrl, boolean generateBidId, JacksonMapper mapper) {
+    public EpsilonBidder(String endpointUrl,
+                         boolean generateBidId,
+                         JacksonMapper mapper,
+                         CurrencyConversionService currencyConversionService) {
         this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl));
         this.generateBidId = generateBidId;
         this.mapper = Objects.requireNonNull(mapper);
+        this.currencyConversionService = Objects.requireNonNull(currencyConversionService);
     }
 
     @Override
@@ -84,22 +93,35 @@ private BidRequest createOutgoingRequest(BidRequest bidRequest) {
         for (int i = 0; i < requestImps.size(); i++) {
             final Imp imp = requestImps.get(i);
             final ExtImpEpsilon impExt = parseImpExt(imp, i);
-            modifiedImps.add(modifyImp(imp, impExt));
+            final BigDecimal bidFloor = resolveBidFloor(bidRequest,
+                    imp.getBidfloorcur(),
+                    getBidFloor(imp.getBidfloor(), impExt.getBidfloor()));
+            modifiedImps.add(modifyImp(imp, impExt, bidFloor));
         }
 
         final Imp firstImp = requestImps.getFirst();
         final ExtImpEpsilon extImp = parseImpExt(firstImp, 0);
         final String siteId = extImp.getSiteId();
         final Site requestSite = bidRequest.getSite();
         final App requestApp = bidRequest.getApp();
-
+        final List<String> cur = bidRequest.getCur();
         return bidRequest.toBuilder()
                 .site(updateSite(requestSite, siteId))
                 .app(requestSite == null ? updateApp(requestApp, siteId) : requestApp)
                 .imp(modifiedImps)
+                .cur(Collections.singletonList(BIDDER_CURRENCY))
                 .build();
     }
 
+    private BigDecimal resolveBidFloor(BidRequest bidRequest, String bidfloorcur, BigDecimal bidfloor) {
+        if (BidderUtil.isValidPrice(bidfloor)
+                && !StringUtils.equalsIgnoreCase(bidfloorcur, BIDDER_CURRENCY)
+                && StringUtils.isNotBlank(bidfloorcur)) {
+            return currencyConversionService.convertCurrency(bidfloor, bidRequest, bidfloorcur, BIDDER_CURRENCY);
+        }
+        return bidfloor;
+    }
+
     private ExtImpEpsilon parseImpExt(Imp imp, int impIndex) {
         final ExtImpEpsilon extImp;
         try {
@@ -122,14 +144,15 @@ private static App updateApp(App app, String siteId) {
         return app == null ? null : app.toBuilder().id(siteId).build();
     }
 
-    private static Imp modifyImp(Imp imp, ExtImpEpsilon impExt) {
+    private static Imp modifyImp(Imp imp, ExtImpEpsilon impExt, BigDecimal bidfloor) {
         final Banner banner = imp.getBanner();
         final Video video = imp.getVideo();
 
         return imp.toBuilder()
                 .displaymanager(DISPLAY_MANAGER)
                 .displaymanagerver(DISPLAY_MANAGER_VER)
-                .bidfloor(getBidFloor(imp.getBidfloor(), impExt.getBidfloor()))
+                .bidfloor(bidfloor)
+                .bidfloorcur(BIDDER_CURRENCY)
                 .tagid(getTagId(imp.getTagid(), impExt.getTagId()))
                 .secure(getSecure(imp, impExt))
                 .banner(modifyBanner(banner, impExt.getPosition()))
diff --git a/src/main/java/org/prebid/server/spring/config/bidder/EpsilonConfiguration.java b/src/main/java/org/prebid/server/spring/config/bidder/EpsilonConfiguration.java
@@ -5,6 +5,7 @@
 import lombok.NoArgsConstructor;
 import org.prebid.server.bidder.BidderDeps;
 import org.prebid.server.bidder.epsilon.EpsilonBidder;
+import org.prebid.server.currency.CurrencyConversionService;
 import org.prebid.server.json.JacksonMapper;
 import org.prebid.server.spring.config.bidder.model.BidderConfigurationProperties;
 import org.prebid.server.spring.config.bidder.util.BidderDepsAssembler;
@@ -34,8 +35,9 @@ EpsilonConfigurationProperties configurationProperties() {
 
     @Bean
     BidderDeps epsilonBidderDeps(EpsilonConfigurationProperties epsilonConfigurationProperties,
-                                    @NotBlank @Value("${external-url}") String externalUrl,
-                                    JacksonMapper mapper) {
+                                 @NotBlank @Value("${external-url}") String externalUrl,
+                                 JacksonMapper mapper,
+                                 CurrencyConversionService currencyConversionService) {
 
         return BidderDepsAssembler.forBidder(BIDDER_NAME)
                 .withConfig(epsilonConfigurationProperties)
@@ -44,7 +46,8 @@ BidderDeps epsilonBidderDeps(EpsilonConfigurationProperties epsilonConfiguration
                         new EpsilonBidder(
                                 config.getEndpoint(),
                                 epsilonConfigurationProperties.getGenerateBidId(),
-                                mapper))
+                                mapper,
+                                currencyConversionService))
                 .assemble();
     }
 
diff --git a/src/main/resources/bidder-config/epsilon.yaml b/src/main/resources/bidder-config/epsilon.yaml
@@ -1,6 +1,6 @@
 adapters:
   epsilon:
-    endpoint: http://api.hb.ad.cpe.dotomi.com/s2s/header/24
+    endpoint: http://api.hb.ad.cpe.dotomi.com/cvx/server/hb/ortb/25
     aliases:
       conversant:
         usersync:
diff --git a/src/test/java/org/prebid/server/bidder/epsilon/EpsilonBidderTest.java b/src/test/java/org/prebid/server/bidder/epsilon/EpsilonBidderTest.java
@@ -10,14 +10,21 @@
 import com.iab.openrtb.response.Bid;
 import com.iab.openrtb.response.BidResponse;
 import com.iab.openrtb.response.SeatBid;
+import org.assertj.core.api.AssertionsForClassTypes;
+import org.junit.Before;
+import org.junit.Rule;
 import org.junit.Test;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnit;
+import org.mockito.junit.MockitoRule;
 import org.prebid.server.VertxTest;
 import org.prebid.server.bidder.model.BidderBid;
 import org.prebid.server.bidder.model.BidderCall;
 import org.prebid.server.bidder.model.BidderError;
 import org.prebid.server.bidder.model.HttpRequest;
 import org.prebid.server.bidder.model.HttpResponse;
 import org.prebid.server.bidder.model.Result;
+import org.prebid.server.currency.CurrencyConversionService;
 import org.prebid.server.proto.openrtb.ext.ExtPrebid;
 import org.prebid.server.proto.openrtb.ext.request.epsilon.ExtImpEpsilon;
 
@@ -32,6 +39,9 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
 import static org.assertj.core.api.Assertions.tuple;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.BDDMockito.given;
 import static org.prebid.server.proto.openrtb.ext.response.BidType.banner;
 import static org.prebid.server.proto.openrtb.ext.response.BidType.video;
 
@@ -41,12 +51,23 @@ public class EpsilonBidderTest extends VertxTest {
     private static final String UUID_REGEX = "[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}"
             + "-[0-9a-fA-F]{12}";
 
-    private EpsilonBidder target = new EpsilonBidder(ENDPOINT_URL, false, jacksonMapper);
+    @Rule
+    public final MockitoRule mockitoRule = MockitoJUnit.rule();
+
+    @Mock
+    private CurrencyConversionService currencyConversionService;
+
+    private EpsilonBidder target;
+
+    @Before
+    public void setUp() {
+        target = new EpsilonBidder(ENDPOINT_URL, false, jacksonMapper, currencyConversionService);
+    }
 
     @Test
     public void creationShouldFailOnInvalidEndpointUrl() {
         assertThatIllegalArgumentException()
-                .isThrownBy(() -> new EpsilonBidder("invalid_url", false, jacksonMapper));
+                .isThrownBy(() -> new EpsilonBidder("invalid_url", false, jacksonMapper, currencyConversionService));
     }
 
     @Test
@@ -595,7 +616,7 @@ public void makeBidsShouldReturnVideoBidIfRequestImpHasVideo() throws JsonProces
     @Test
     public void makeBidsShouldUpdateBidWithUUIDIfGenerateBidIdIsTrue() throws JsonProcessingException {
         // given
-        target = new EpsilonBidder(ENDPOINT_URL, true, jacksonMapper);
+        target = new EpsilonBidder(ENDPOINT_URL, true, jacksonMapper, currencyConversionService);
         final BidderCall<BidRequest> httpCall = givenHttpCall(
                 givenBidRequest(builder -> builder.id("123")
                         .banner(Banner.builder().build())),
@@ -652,6 +673,27 @@ public void makeHttpRequestsShouldNotSetImpBidFloorFromImpExt() {
                 .containsExactly(BigDecimal.valueOf(-1.00));
     }
 
+    @Test
+    public void makeHttpRequestsShouldReturnConvertedBidFloorCurrency() {
+        // given
+        given(currencyConversionService.convertCurrency(any(), any(), anyString(), anyString()))
+                .willReturn(BigDecimal.ONE);
+
+        final BidRequest bidRequest = givenBidRequest(
+                impBuilder -> impBuilder.bidfloor(BigDecimal.TEN).bidfloorcur("EUR"));
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
+
+        // then
+        assertThat(result.getErrors()).isEmpty();
+        assertThat(result.getValue())
+                .extracting(HttpRequest::getPayload)
+                .flatExtracting(BidRequest::getImp)
+                .extracting(Imp::getBidfloor, Imp::getBidfloorcur)
+                .containsOnly(AssertionsForClassTypes.tuple(BigDecimal.ONE, "USD"));
+    }
+
     private static BidRequest givenBidRequest(
             Function<BidRequest.BidRequestBuilder, BidRequest.BidRequestBuilder> bidRequestCustomizer,
             Function<Imp.ImpBuilder, Imp.ImpBuilder> impCustomizer,
diff --git a/src/test/resources/org/prebid/server/it/openrtb2/epsilon/alias/test-epsilon-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/epsilon/alias/test-epsilon-bid-request.json
@@ -8,6 +8,7 @@
         "w": 300,
         "h": 600
       },
+      "bidfloorcur": "USD",
       "displaymanager": "prebid-s2s",
       "displaymanagerver": "2.0.0",
       "ext": {
diff --git a/src/test/resources/org/prebid/server/it/openrtb2/epsilon/test-epsilon-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/epsilon/test-epsilon-bid-request.json
@@ -8,6 +8,7 @@
         "w": 300,
         "h": 600
       },
+      "bidfloorcur": "USD",
       "displaymanager": "prebid-s2s",
       "displaymanagerver": "2.0.0",
       "ext": {
