Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced documentation for Docker Compose #81

Closed
roop90 opened this issue Nov 1, 2022 · 3 comments
Closed

Enhanced documentation for Docker Compose #81

roop90 opened this issue Nov 1, 2022 · 3 comments
Labels
enhancement question

Comments

@roop90
Copy link

roop90 commented Nov 1, 2022 •
edited
Loading

Update:

Forget about my text below. I was simply confused by the documentation.
I've added a more complete example for Docker Compose / Docker Swarm.

Cheers.

Old Text

Hi there.

I've placed a service on the ignorelist, which is recognized to be excluded.
Yet, shepherd tries to update the service.

I've looked into the code but couldn't find any hints.

Version used: mazzolino/shepherd:latest (0.7.0)

Here's my log output:

Tue Nov  1 23:08:05 CET 2022 Timezone set to Europe/Berlin
Tue Nov  1 23:08:05 CET 2022 Enabling synchronous service updates
Tue Nov  1 23:08:05 CET 2022 Excluding services: "tools_swarm-cleanup"
Tue Nov  1 23:08:10 CET 2022 Trying to update service gameservers_minecraft-1 with image itzg/minecraft-server:java17-graalvm-ce
Tue Nov  1 23:08:17 CET 2022 No updates to service gameservers_minecraft-1!
Tue Nov  1 23:08:24 CET 2022 Trying to update service tools_shepherd with image mazzolino/shepherd:latest
Tue Nov  1 23:08:31 CET 2022 No updates to service tools_shepherd!
Tue Nov  1 23:08:36 CET 2022 Trying to update service tools_swarm-cleanup with image docker:latest

yml file for shepherd:

version: "3"

services:
  shepherd:
    image: mazzolino/shepherd
    environment:
      - TZ=Europe/Berlin
      - IGNORELIST_SERVICES="tools_swarm-cleanup"
      - ROLLBACK_ON_FAILURE="true"
      - IMAGE_AUTOCLEAN_LIMIT=1
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    deploy:
      placement:
        constraints:
        - node.role == manager

Let me know, if you need more Infos.
@roop90
Copy link
Author

roop90 commented Nov 2, 2022 •
edited
Loading

Update:

I found the issue. It's kinda dumb.
I've copied those lines from the Readme:

IGNORELIST_SERVICES="tools_swarm-cleanup"
ROLLBACK_ON_FAILURE="true"

This on the other hand works just fine:

IGNORELIST_SERVICES=tools_swarm-cleanup
ROLLBACK_ON_FAILURE=true

roop90 referenced this issue in roop90/shepherd Nov 3, 2022
@roop90
Add example for docker-compose and Docker Swarm (djmaze#81)
6829d25
@roop90 roop90 mentioned this issue Nov 3, 2022
Closed
@roop90 roop90 changed the title Service on Ignorelist is still updated Enhanced documentation for Docker Compose Nov 3, 2022
@Leopere
Copy link

Leopere commented Jul 6, 2023

I personally would really just like a docker label for each container I don't really want to upgrade all services every time.

@moschlar
Copy link
Collaborator

Yes, quoting is hard, here - bit me too some time ago.
Sometimes quoting is applied at the shell or yaml level and sometimes, quotes get copied verbatim (OTOH when using a docker-compose.yml with env: ['VAR="value"'].

We'll add examples and a note about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Full example for docker-compose and Docker Swarm roop90/shepherd
3 participants
@moschlar @Leopere @roop90