set !remote build tags where needed

The new golangci-lint version 1.60.1 has problems with typecheck when
linting remote files. We have certain pakcages that should never be
inlcuded in remote but the typecheck tries to compile all of them but
this never works and it seems to ignore the exclude files we gave it.

To fix this the proper way is to mark all packages we only use locally
with !remote tags. This is a bit ugly but more correct. I also moved the
DecodeChanges() code around as it is called from the client so the
handles package which should only be remote doesn't really fit anyway.

Signed-off-by: Paul Holzinger <[email protected]>

Author: Luap99

cmd/podman-testing/create.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package main
 
 import (

cmd/podman-testing/data.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package main
 
 import (

cmd/podman-testing/layer.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package main
 
 import (

cmd/podman-testing/main.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package main
 
 import (

cmd/podman-testing/remove.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package main
 
 import (

cmd/podman-testing/store_supported.go

@@ -1,5 +1,4 @@
 //go:build linux && !remote
-// +build linux,!remote
 
 package main
 

cmd/podman-testing/store_unsupported.go

@@ -9,7 +9,6 @@ import (
 	"github.com/containers/common/pkg/completion"
 	"github.com/containers/podman/v5/cmd/podman/common"
 	"github.com/containers/podman/v5/cmd/podman/registry"
-	"github.com/containers/podman/v5/pkg/api/handlers"
 	"github.com/containers/podman/v5/pkg/domain/entities"
 	"github.com/spf13/cobra"
 )
@@ -105,9 +104,6 @@ func commit(cmd *cobra.Command, args []string) error {
 	if !commitOptions.Quiet {
 		commitOptions.Writer = os.Stderr
 	}
-	if len(commitOptions.Changes) > 0 {
-		commitOptions.Changes = handlers.DecodeChanges(commitOptions.Changes)
-	}
 	if len(configFile) > 0 {
 		cfg, err := os.ReadFile(configFile)
 		if err != nil {

cmd/podman/containers/commit.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package entities
 
 import (

internal/domain/entities/engine_testing.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package entities
 
 type CreateStorageLayerOptions struct {