Skip to content

Conversation

@Cali0707
Copy link
Collaborator

I noticed that with the gevals change to builtin agents, we are now declaring the model manually in the eval spec. This updates that model from gpt-4 to gpt-5

@nader-ziada
Copy link
Collaborator

can you update the evals/README.md as well

@manusa manusa added this to the 0.1.0 milestone Nov 28, 2025
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however, I'm not sure how:

MODEL_NAME: ${{ secrets.MODEL_NAME }}

JUDGE_MODEL_NAME: ${{ secrets.JUDGE_MODEL_NAME }}

relate to this value

@Cali0707
Copy link
Collaborator Author

Looks good, however, I'm not sure how:

MODEL_NAME: ${{ secrets.MODEL_NAME }}

JUDGE_MODEL_NAME: ${{ secrets.JUDGE_MODEL_NAME }}

relate to this value

I think we should be good to remove them now. I hadn't realized that part of the scope of changes related to the builtin models was to specify the model name through the yaml and not through env vars when I opened this PR (my bad!). Personally, I think it is cleaner now :)

@Cali0707 Cali0707 requested a review from manusa November 28, 2025 13:33
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit a7528b6 into containers:main Nov 28, 2025
6 checks passed
@manusa
Copy link
Member

manusa commented Nov 28, 2025

Removed MODEL_NAME from secrets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants