Skip to content

Commit 60f6c05

Browse files
committed
Comments from review
Signed-off-by: josunect <[email protected]>
1 parent e1b6604 commit 60f6c05

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

docs/KIALI.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@ When the `kiali` toolset is enabled, a Kiali toolset configuration is required v
3030
- Missing Kiali configuration when `kiali` toolset is enabled → set `[toolset_configs.kiali].url` in the config TOML.
3131
- Invalid URL → ensure `[toolset_configs.kiali].url` is a valid `http(s)://host` URL.
3232
- TLS certificate validation:
33-
- If `[toolset_configs.kiali].url` uses HTTPS and `[toolset_configs.kiali].insecure` is false, you must set `[toolset_configs.kiali].certificate_authority` with the path to the CA certificate file. Relative paths are resolved relative to the directory containing the config file. Only file paths are supported; inline PEM content is not allowed.
33+
- If `[toolset_configs.kiali].url` uses HTTPS and `[toolset_configs.kiali].insecure` is false, you must set `[toolset_configs.kiali].certificate_authority` with the path to the CA certificate file. Relative paths are resolved relative to the directory containing the config file.
3434
- For non-production environments you can set `[toolset_configs.kiali].insecure = true` to skip certificate verification.
3535

pkg/config/config.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ func withDirPath(path string) ReadConfigOpt {
9898
// WithDirPath returns a ReadConfigOpt that sets the config directory path.
9999
// Used by tests that need to resolve relative file paths.
100100
func WithDirPath(path string) ReadConfigOpt {
101-
102101
return withDirPath(path)
103102
}
104103

0 commit comments

Comments
 (0)