Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generation issue for endpoints without a response payload #13

Open
judgej opened this issue Sep 6, 2019 · 2 comments
Open

Generation issue for endpoints without a response payload #13

judgej opened this issue Sep 6, 2019 · 2 comments
Assignees
@judgej
Labels
bug Something isn't working

Comments

@judgej
Copy link
Member

judgej commented Sep 6, 2019

When there is no response payload, the generated code is not complete.

More details to come when I have a little more time.
@judgej judgej added the bug Something isn't working label Sep 6, 2019
@judgej judgej self-assigned this Sep 6, 2019
judgej added a commit that referenced this issue Sep 6, 2019
@judgej
Issue #13 fix sync generation code.
6e74bc4
@judgej
Copy link
Member Author

judgej commented Sep 6, 2019

The async generation code will need a similar fix.

@judgej
Copy link
Member Author

judgej commented Sep 6, 2019

Also added a quick fix to the exception that is thrown when a response returns a non-2xx code. The model (deserialised/compiled payload) is also added to the exception. So a validation error may throw a 404 exception, but if it also includes an RFC7803 payload with details of the validation error or errors, then that payload model is available in the exception as well as the original PSR-7 request and response messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@judgej judgej

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@judgej