Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't be able to delete a vault while asking for consento #66

Open
marcchataigner-zz opened this issue Feb 10, 2020 · 3 comments
Open
Assignees
Labels
enhancement New feature or request ux User experience issue/question
Milestone

Comments

@marcchataigner-zz
Copy link

When waiting for a vault to be unlocked, the vault can be deleted. This feature should be disabled at this stage.

Only when the vault is open, the vault can be edited or deleted.

IMG_2611

IMG_2612

@marcchataigner-zz marcchataigner-zz added enhancement New feature or request ux User experience issue/question labels Feb 10, 2020
@marcchataigner-zz marcchataigner-zz added this to the Release 1.0.2 milestone Feb 10, 2020
@dkastl dkastl modified the milestones: Release 1.0.2, Release 1.0.3 Feb 10, 2020
@martinheidegger
Copy link
Member

From the perspective of the owner of the vault, it should be possible to delete a vault, even ifs not "open-able", right? I mean: it might be the case that the selected lockees are uncooperative, making a certain vault dead. Seems like a good idea to be able to delete it in that case.

What needs to happen though is that any existing request regarding the vault should be cancelled. I.e.: the lockee's should be relieved of their duty and any open request cancelled.

@marcchataigner-zz
Copy link
Author

I see. It is true that perhaps I need to make space on my device, no matter what.

What if when I tap the vault in the vault list, it leads to a page with a unlock button. So I don't have to send a request and I may delete the vault.

@martinheidegger
Copy link
Member

What if when I tap the vault in the vault list, it leads to a page with a unlock button. So I don't have to send a request and I may delete the vault.

That is possible, and might be an improvement but we may be balancing the common use-case (unlocking) vs. the uncommon use-case (delete) here. As an alternative we could implement a "long-press-for-delete" method in the vault-overview: Pressing for a long time to show a delete icon on the vault or opens an dialog for confirmation of deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux User experience issue/question
Projects
None yet
Development

No branches or pull requests

3 participants