decrypt: Improve error handling #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced `get_plaintext_layer()` so that it passes the full error back
to the caller, along with error context. This resolves the issue of the
method returning a generic "decrypt failed" message. Now, we return
something like:
```
decrypt failed
Caused by:
missing private key needed for decryption
```
This change necessitated reworking the tests to assert that the expected
error stack / context is checked.
Fixes: #92.
Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
requested review from
sameo,
jiangliu,
arronwy,
lumjjb and
jialez0
as code owners
|
It's partially handled by #99 :) |
|
Hi @jodh-intel , could you help rebase this PR against lastest main branch since #99 is just merged? |
|
Any thoughts folks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced
get_plaintext_layer()so that it passes the full error back to the caller, along with error context. This resolves the issue of the method returning a generic "decrypt failed" message. Now, we return something like:This change necessitated reworking the tests to assert that the expected error stack / context is checked.
Fixes: #92.
Signed-off-by: James O. D. Hunt [email protected]