Skip to content

Enhancement: DripFactory::MAX_BATCH_SIZE is a hardcoded constant, unlike every other protocol-wide bound #314

Description

@Jaydbrown

contracts/factory/src/lib.rs defines pub const MAX_BATCH_SIZE: u32 = 100;, used by both create_batch_streams and cancel_batch_streams to cap batch sizes. Every other protocol-wide numeric bound in the system — fee_bps, min_duration_seconds, max_duration_seconds, max_rate_per_second — lives in DripGovernor and is adjustable by a role-gated setter without a contract upgrade. MAX_BATCH_SIZE is the one remaining bound that can only be changed by uploading new factory WASM via upgrade_stream_wasm (which, per the earlier issue on that function, doesn't even upgrade the factory's own code) or a fresh deploy. Worth considering whether batch-size limits belong in DripGovernor::GovernorConfig alongside the other tunables.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions