Enhancement: TwapOracle::configure_oracle doesn't validate max_staleness

[Jaydbrown]

TwapOracle::configure_oracle (contracts/oracle/src/lib.rs) validates decimals > 38 but never validates max_staleness. If an admin sets max_staleness: 0, every submission becomes stale essentially immediately (get_twap_price's age <= config.max_staleness can basically never hold once even one ledger has passed), silently bricking the oracle for all readers — get_twap_price will return OracleStalePrice forever without any distinct error indicating the configuration itself is degenerate. A max_staleness == 0 check (mirroring the decimals guard) would surface this at configuration time instead.

[Chris-P-web]

@Chris-P-web has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

‎Hi Maintainer! I'd love to contribute to this issue. I can deliver a clean implementation while ensuring it's completed promptly and meets all requirements.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Chris-P-web to this issue.

[brimo8]

@brimo8 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi Maintainer! I’m eager to contribute to this task and look forward to delivering a well-structured, reliable solution on time.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @brimo8 to this issue.

[Gabbydunkk]

@Gabbydunkk has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

PLS ASSIGN TO ME

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Gabbydunkk to this issue.

[drips-wave]

Congratulations, @Gabbydunkk! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Gabbydunkk: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊