Repository navigation
Commit c98a1ca
committed
test: remove two sources of flakiness in the integration suite
Two failures in run 32109693272, neither related to region-durable.
testWfSyncExecutionSignalAsync ended "Workflow ended in unexpected state:
FAILED". It, testWfExecutionSignalAsync and testWfDurableExecutionSignalAsync
all did:
Thread.sleep(20); // "Wait for initial execution"
taskClient.signalAsync(workflowId, COMPLETED, ...);
20ms is not a wait, it is a coin flip — signalling before the task exists.
All three now poll until the workflow is RUNNING with a non-terminal task
(TestUtil.waitUntilSignalable). Only one of the three lost the toss this run;
fixing just that one would leave the other two armed.
testSearchTasks failed with SocketTimeoutException from taskClient.search.
It slept a fixed 5s then made a single call, which raced asynchronous search
indexing and had no tolerance for a slow response. Now retries until the call
answers (TestUtil.retryUntil).
Also: waitForWorkflowStatus threw "ended in unexpected state: FAILED" and
discarded the reason, which is why the cause of the above was not visible in
CI at all. It now reports reasonForIncompletion and per-task status/reason,
and the timeout path reports task states too.
Caveat: the signal race is the likely cause of the FAILED workflow but is not
proven — the reason was never logged. The added diagnostics mean a recurrence
will say so outright.1 parent ffa272f commit c98a1ca
2 files changed
Lines changed: 92 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
484 | 484 | | |
485 | 485 | | |
486 | 486 | | |
487 | | - | |
488 | | - | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
489 | 490 | | |
490 | 491 | | |
491 | 492 | | |
| |||
509 | 510 | | |
510 | 511 | | |
511 | 512 | | |
512 | | - | |
513 | | - | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
514 | 516 | | |
515 | 517 | | |
516 | 518 | | |
| |||
534 | 536 | | |
535 | 537 | | |
536 | 538 | | |
537 | | - | |
538 | | - | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
539 | 542 | | |
540 | 543 | | |
541 | 544 | | |
| |||
742 | 745 | | |
743 | 746 | | |
744 | 747 | | |
745 | | - | |
| 748 | + | |
746 | 749 | | |
747 | 750 | | |
748 | 751 | | |
749 | 752 | | |
750 | 753 | | |
751 | 754 | | |
752 | 755 | | |
753 | | - | |
754 | | - | |
755 | | - | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
756 | 761 | | |
757 | 762 | | |
758 | 763 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
127 | | - | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
128 | 202 | | |
129 | 203 | | |
0 commit comments