Skip to content

Commit 856be12

Browse files
attempt to improve flaky test by removing a redundant call to startPolling
1 parent ae3c67f commit 856be12

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎tests/src/test/java/io/orkes/conductor/sdk/WorkflowSDKTests.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ public void testCreateWorkflow() throws Exception {
4040
ConductorClient client = ClientTestUtil.getClient();
4141

4242
AnnotatedWorkerExecutor workerExecutor = new AnnotatedWorkerExecutor(new TaskClient(client), new WorkerConfiguration());
43+
// initWorkers() already starts polling; a redundant extra startPolling() call here used to race with AnnotatedWorkerExecutor's own double-start (likely a real bug there) and could drop the first polled task.
4344
workerExecutor.initWorkers("io.orkes.conductor.sdk");
44-
workerExecutor.startPolling();
4545

4646
WorkflowExecutor executor = new WorkflowExecutor(client, workerExecutor);
4747

0 commit comments

Comments
 (0)