Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip req version specifier order is non-deterministic, breaking content_hash #274

Closed
maresb opened this issue Nov 7, 2022 · 0 comments · Fixed by #277
Closed

pip req version specifier order is non-deterministic, breaking content_hash #274

maresb opened this issue Nov 7, 2022 · 0 comments · Fixed by #277
Assignees

Comments

@maresb
Copy link
Contributor

maresb commented Nov 7, 2022

If I have an environment.yml with

...
- pip
- pip:
  - some-pypi-package >=1.2.3,<2.0.0

then the content_hash is half-of-the-time based on an env_spec with >=1.2.3,<2.0.0 and the other half with <2.0.0,>=1.2.3.

Similar bugs that I have seen all result from a Python set is being used, because it orders elements randomly.

Note: for whoever manages to work on this, it may be worthwhile to also look into #273 since it also deals with aggregation of version specifiers on PyPI packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants