Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using pkg-config #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AdrianFreundQC
Copy link

@AdrianFreundQC AdrianFreundQC commented Jul 16, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@AdrianFreundQC
Copy link
Author

Next attempt after leaving this change out of #20.

Cross-compiling fails with

run pkg_config fail: pkg-config has not been configured to support cross-compilation.

Install a sysroot for the target platform and configure it via
PKG_CONFIG_SYSROOT_DIR and PKG_CONFIG_PATH, or install a
cross-compiling wrapper for pkg-config and set it via
PKG_CONFIG environment variable.

Manually setting PKG_CONFIG_SYSROOT_DIR makes pkg-config find the library, but later causes linking to fail.

Note that in this feedstock it only fails on Linux, as the MacOS build doesn't link against OpenSSL, but MacOS's native SSL library, which doesn't require using pkg-config.

Also see the two different workarounds at conda-forge/cargo-bundle-licenses-feedstock#8 and conda-forge/cargo-c-feedstock#1, the bug report at conda-forge/rust-activation-feedstock#35 as well as the documentation for rust's pkg-config crate: https://docs.rs/pkg-config/latest/pkg_config/.

This issue should ideally be solved in rust-activation-feedstock so different feedstocks don't need to copy-and-paste the same build scripts over and over.

CC: @pavelzw @xhochy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants