Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding package: CMS Combine statistics tool #29267

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nsmith-
Copy link

@nsmith- nsmith- commented Feb 25, 2025

This is a statistical analysis tool used by the Compact Muon Solenoid collaboration. Official documentation is found at https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest/

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/cms-combine/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: anigamova, kcormi. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 25, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cms-combine/meta.yaml) and found some lint.

Here's what I've got...

For recipes/cms-combine/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [24, 25]

For recipes/cms-combine/meta.yaml:

  • ℹ️ The boost-cpp output has been superseded by libboost-devel (as of 1.82), which now comes with a run-export (on libboost) as well. In case you only needed the boost headers, you should use libboost-headers.
  • ℹ️ You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.
  • ℹ️ No valid build backend found for Python recipe for package cms-combine using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13512579395. Examine the logs at this URL for more detail.

extra:
recipe-maintainers:
- nsmith-
- kcormi
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kcormi @anigamova FYI I have added you as maintainers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that they will both need to respond that they approve for the linting to pass.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nsmith-, fine with me of course!

@nsmith- nsmith- changed the title Implement a conda package for CMS Combine statistics tool Adding package: CMS Combine statistics tool Feb 25, 2025
@nsmith-
Copy link
Author

nsmith- commented Feb 25, 2025

FYI @matthewfeickert

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cms-combine/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncsmith I'm seeing a lot of

x86_64-apple-darwin13.4: warning: argument unused during compilation: '--param vect-max-version-for-alias-checks=50' [-Wunused-command-line-argument]
warning: unknown warning option '-Werror=format-contains-nul' [-Wunknown-warning-option]
warning: unknown warning option '-Wno-non-template-friend'; did you mean '-Wno-unsupported-friend'? [-Wunknown-warning-option]
2 warnings generated.

in the osx-64 build. Is this expected?

(It does pass though, so that's a positive. 👍)

build:
number: 0
skip: true # [win]
ignore_run_exports: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have python as a run requirement, why are you adding it to ignore_run_exports?

extra:
recipe-maintainers:
- nsmith-
- kcormi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that they will both need to respond that they approve for the linting to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants