-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding package: CMS Combine statistics tool #29267
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cms-combine/meta.yaml:
For recipes/cms-combine/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13512579395. Examine the logs at this URL for more detail. |
extra: | ||
recipe-maintainers: | ||
- nsmith- | ||
- kcormi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kcormi @anigamova FYI I have added you as maintainers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that they will both need to respond that they approve for the linting to pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @nsmith-, fine with me of course!
FYI @matthewfeickert |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ncsmith I'm seeing a lot of
x86_64-apple-darwin13.4: warning: argument unused during compilation: '--param vect-max-version-for-alias-checks=50' [-Wunused-command-line-argument]
warning: unknown warning option '-Werror=format-contains-nul' [-Wunknown-warning-option]
warning: unknown warning option '-Wno-non-template-friend'; did you mean '-Wno-unsupported-friend'? [-Wunknown-warning-option]
2 warnings generated.
in the osx-64
build. Is this expected?
(It does pass though, so that's a positive. 👍)
build: | ||
number: 0 | ||
skip: true # [win] | ||
ignore_run_exports: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have python
as a run
requirement, why are you adding it to ignore_run_exports
?
extra: | ||
recipe-maintainers: | ||
- nsmith- | ||
- kcormi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that they will both need to respond that they approve for the linting to pass.
This is a statistical analysis tool used by the Compact Muon Solenoid collaboration. Official documentation is found at https://cms-analysis.github.io/HiggsAnalysis-CombinedLimit/latest/
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).