-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: openfast_io recipe to conda-forge #29112
Conversation
@conda-forge/help-python |
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/openfast_io/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13296733654. Examine the logs at this URL for more detail. |
I'm happy to be a maintainer! |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
New to the process here. This looks good to me! Happy to join as a maintainer. |
@conda-forge-admin, please rerender |
@conda-forge/help-python, ready for review! |
Co-authored-by: Joshua Adelman <[email protected]>
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
about: | ||
home: https://github.com/openfast/openfast | ||
license: Apache-2.0 | ||
license_file: LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license file is missing from the source distribution. You should add a manual copy here and raise an issue upstream to fix it so the manual copy can be removed in a future release:
https://conda-forge.org/docs/maintainer/adding_pkgs/#packaging-the-license-manually
Closing this PR since conda-forge/admin-requests#1385 Additional ref: Thank you for the support and quick response @synapticarbors |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).