Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: openfast_io recipe to conda-forge #29112

Closed
wants to merge 3 commits into from

Conversation

mayankchetan
Copy link

@mayankchetan mayankchetan commented Feb 12, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@mayankchetan
Copy link
Author

@conda-forge/help-python

Copy link
Contributor

github-actions bot commented Feb 12, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/openfast_io/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: andrew-platt. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/openfast_io/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/openfast_io/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13296733654. Examine the logs at this URL for more detail.

@deslaughter
Copy link

I'm happy to be a maintainer!

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/openfast_io/meta.yaml) and found it was in an excellent condition.

@andrew-platt
Copy link

New to the process here. This looks good to me! Happy to join as a maintainer.

@andrew-platt
Copy link

@conda-forge-admin, please rerender

@mayankchetan
Copy link
Author

@conda-forge/help-python, ready for review!

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

about:
home: https://github.com/openfast/openfast
license: Apache-2.0
license_file: LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license file is missing from the source distribution. You should add a manual copy here and raise an issue upstream to fix it so the manual copy can be removed in a future release:
https://conda-forge.org/docs/maintainer/adding_pkgs/#packaging-the-license-manually

@mayankchetan
Copy link
Author

Closing this PR since openfast_io is being added as an output to the existing openfast feedstock. This will allow easier release in the future

conda-forge/admin-requests#1385

Additional ref:
conda-forge/openfast-feedstock#58

Thank you for the support and quick response @synapticarbors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants