Skip to content

Create Conda recipe of MontePy #28428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 16, 2024
Merged

Create Conda recipe of MontePy #28428

merged 14 commits into from
Dec 16, 2024

Conversation

MicahGale
Copy link
Contributor

@MicahGale MicahGale commented Dec 3, 2024

MontePy is a Python library for reading, editing, and writing MCNP input files. Monte Carlo N-Particle (MCNP) is a widely used Monte Carlo radiation transport code for the nuclear engineering and scientific community.

MontePy only depends on:

  • Numpy
  • SLY. Previously MontePy required SLY 0.5. We started testing against SLY 0.4, and were able to relax our requirements to include SLY 0.4. Though there is currently an open PR to add SLY 0.5 to conda-forge: Update to release 0.5 sly-feedstock#2

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@MicahGale
Copy link
Contributor Author

I am ok with being a maintainer for MontePy.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/montepy/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/montepy/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12133393915. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/montepy/meta.yaml) and found it was in an excellent condition.

@MicahGale MicahGale marked this pull request as ready for review December 12, 2024 22:03
@MicahGale
Copy link
Contributor Author

MicahGale commented Dec 12, 2024

@conda-forge-admin, please ping team conda-forge/help-python

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@MicahGale
Copy link
Contributor Author

@conda-forge/help-python ready for review.

@conda-forge-admin, please ping team.

Sorry for the confusion with the bots.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team. and so here I am doing that.

@MicahGale MicahGale requested a review from ocefpaf December 13, 2024 23:07
@ocefpaf ocefpaf merged commit 5dc8d96 into conda-forge:main Dec 16, 2024
7 checks passed
@MicahGale MicahGale deleted the montepy branch December 16, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants