Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libprotobuf 22.3 #153

Closed
wants to merge 6 commits into from
Closed

libprotobuf 22.3 #153

wants to merge 6 commits into from

Conversation

sh-shahrokhi
Copy link

@sh-shahrokhi sh-shahrokhi commented Apr 16, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xylar
Copy link
Contributor

xylar commented Apr 16, 2023

@sh-shahrokhi, I think we're going to need a little while before we can move to 22.x, see his comment:
conda-forge/protobuf-feedstock#180 (comment)

@h-vetinari, any update on that?

@h-vetinari
Copy link
Member

Waiting for grpc 1.54 and the corresponding migration, which is compatible with the new protobuf.

@xylar
Copy link
Contributor

xylar commented Apr 16, 2023

@h-vetinari, great thanks!

@sh-shahrokhi
Copy link
Author

@h-vetinari, great thanks!

ok so I close this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants