This repository has been archived by the owner on Sep 13, 2019. It is now read-only.
feat: Added empty demo file #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In terms of actual code, all I've done is add the file empty.txt to this repository. I got rid of the other commits because frankly, you don't care about how many times I changed my mind about what to name it. All you really wanted to know is that I added the file. Furthermore this is an example of a commit that follows conventional changelog commit formatting guidelines. It is an example of version control as documentation and is a powerful way to communicate your thoughts and rationale to other developers. Because I've created a demo issue on our eng-talks repository located at #1 you can see that I a referencing my demo issue in the footer below. Another nice feature of github and other cloud based VCS systems it that it automatically links to the demo issue I created using the hash syntax, linking this commit and the issue in our repository. Issue #1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I've created an example of a well documented change that I am now submitted for review to the maintainers of the repository. If this weren't a demo I would talk about the major changes I made, and what the ramifications are.