From 6e505605266a1206339d61914e7235954f15bd89 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 26 Sep 2026 13:26:16 +0000 Subject: [PATCH] CI: require the OsPath build flag in the build-flags check git-annex's OsPath flag is Default: True but not Manual, so when a dependency is missing `Setup configure` silently builds without it. That is how our Ubuntu standalone lost it: the buildenv image lacked file-io >= 0.2.0 (fixed in #295), and nothing noticed because the "expected build flags" check only looked for Assistant, MagicMime, Servant and S3. All four platforms now build with OsPath (latest runs: Ubuntu 36238422515, Windows 36230645908, macOS 36223958127, macOS ARM64 36223802082), so require it everywhere. Edited the template and regenerated the workflows with `make -C .github/workflows/template`. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_013n9Q2igij49kxdtiakUzYv --- .github/workflows/build-macos-arm64.yaml | 2 +- .github/workflows/build-macos.yaml | 2 +- .github/workflows/build-ubuntu.yaml | 2 +- .github/workflows/build-windows.yaml | 2 +- .github/workflows/template/build-{{ostype}}.yaml.j2 | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-macos-arm64.yaml b/.github/workflows/build-macos-arm64.yaml index fc3815b1e0..397f24df37 100644 --- a/.github/workflows/build-macos-arm64.yaml +++ b/.github/workflows/build-macos-arm64.yaml @@ -239,7 +239,7 @@ jobs: run: | # apparently order is not alphabetic, so cannot be relied upon for a single grep flags=$(git annex version | grep 'build flags:') - for f in Assistant MagicMime Servant S3; do + for f in Assistant MagicMime Servant S3 OsPath; do echo -n "Checking for $f: " echo "$flags" | grep --color "$f" || { echo "FAIL"; exit 1; } done diff --git a/.github/workflows/build-macos.yaml b/.github/workflows/build-macos.yaml index b8c8e91b22..73a314a1b2 100644 --- a/.github/workflows/build-macos.yaml +++ b/.github/workflows/build-macos.yaml @@ -238,7 +238,7 @@ jobs: run: | # apparently order is not alphabetic, so cannot be relied upon for a single grep flags=$(git annex version | grep 'build flags:') - for f in Assistant MagicMime Servant S3; do + for f in Assistant MagicMime Servant S3 OsPath; do echo -n "Checking for $f: " echo "$flags" | grep --color "$f" || { echo "FAIL"; exit 1; } done diff --git a/.github/workflows/build-ubuntu.yaml b/.github/workflows/build-ubuntu.yaml index 98b8c76824..fa953953b7 100644 --- a/.github/workflows/build-ubuntu.yaml +++ b/.github/workflows/build-ubuntu.yaml @@ -279,7 +279,7 @@ jobs: run: | # apparently order is not alphabetic, so cannot be relied upon for a single grep flags=$(git annex version | grep 'build flags:') - for f in Assistant MagicMime Servant S3; do + for f in Assistant MagicMime Servant S3 OsPath; do echo -n "Checking for $f: " echo "$flags" | grep --color "$f" || { echo "FAIL"; exit 1; } done diff --git a/.github/workflows/build-windows.yaml b/.github/workflows/build-windows.yaml index 6af6b196d6..27b1677bb5 100644 --- a/.github/workflows/build-windows.yaml +++ b/.github/workflows/build-windows.yaml @@ -261,7 +261,7 @@ jobs: run: | # apparently order is not alphabetic, so cannot be relied upon for a single grep flags=$(git annex version | grep 'build flags:') - for f in Assistant MagicMime Servant S3; do + for f in Assistant MagicMime Servant S3 OsPath; do echo -n "Checking for $f: " echo "$flags" | grep --color "$f" || { echo "FAIL"; exit 1; } done diff --git a/.github/workflows/template/build-{{ostype}}.yaml.j2 b/.github/workflows/template/build-{{ostype}}.yaml.j2 index 8b33b0a8d0..0ae34ada4d 100644 --- a/.github/workflows/template/build-{{ostype}}.yaml.j2 +++ b/.github/workflows/template/build-{{ostype}}.yaml.j2 @@ -456,7 +456,7 @@ jobs: run: | # apparently order is not alphabetic, so cannot be relied upon for a single grep flags=$(git annex version | grep 'build flags:') - for f in Assistant MagicMime Servant S3; do + for f in Assistant MagicMime Servant S3 OsPath; do echo -n "Checking for $f: " echo "$flags" | grep --color "$f" || { echo "FAIL"; exit 1; } done