Skip to content

Commit 66419a1

Browse files
committed
Fetch node24 from conda-forge
1 parent bf4eabc commit 66419a1

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

.github/workflows/deploy-github-page.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,12 @@ jobs:
6666
..
6767
emmake make -j ${{ env.ncpus }} install
6868
69-
- name: Setup Node.js 24
70-
uses: actions/setup-node@v4
71-
with:
72-
node-version: '24'
73-
7469
- name: Test xeus-cpp C++ Emscripten
7570
shell: bash -l {0}
7671
run: |
7772
set -e
73+
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyter_server jupyterlite-xeus nodejs=24 -c conda-forge
74+
micromamba activate xeus-lite-host
7875
cd build/test
7976
# Fresh install browsers, and run Emscripten tests in them
8077
# This is to match the Emscripten build instructions, where
@@ -137,14 +134,12 @@ jobs:
137134
echo "Running test_xeus_cpp in Google Chrome"
138135
python ${{ env.BUILD_PREFIX }}/bin/emrun.py --browser="google-chrome" --kill_exit --timeout 60 --browser-args="--headless --no-sandbox" test_xeus_cpp.html
139136
fi
140-
node --version
141137
node test_xeus_cpp.js
142138
timeout-minutes: 4
143139

144140
- name: Jupyter Lite integration
145141
shell: bash -l {0}
146142
run: |
147-
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyter_server jupyterlite-xeus -c conda-forge
148143
micromamba activate xeus-lite-host
149144
jupyter lite build \
150145
--XeusAddon.prefix=${{ env.PREFIX }} \

.github/workflows/main.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -249,11 +249,6 @@ jobs:
249249
..
250250
emmake make -j ${{ env.ncpus }} install
251251
252-
# - name: Setup Node.js 24
253-
# uses: actions/setup-node@v4
254-
# with:
255-
# node-version: '24'
256-
257252
- name: Test xeus-cpp C++ Emscripten
258253
shell: bash -l {0}
259254
run: |
@@ -328,14 +323,12 @@ jobs:
328323
echo "Running test_xeus_cpp in Google Chrome"
329324
python ${{ env.BUILD_PREFIX }}/bin/emrun.py --browser="google-chrome" --kill_exit --timeout 60 --browser-args="--headless --no-sandbox" test_xeus_cpp.html
330325
fi
331-
node --version
332326
node test_xeus_cpp.js
333327
timeout-minutes: 4
334328

335329
- name: Jupyter Lite integration
336330
shell: bash -l {0}
337331
run: |
338-
# micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyter_server jupyterlite-xeus -c conda-forge
339332
micromamba activate xeus-lite-host
340333
jupyter lite build --XeusAddon.prefix=${{ env.PREFIX }}
341334

0 commit comments

Comments
 (0)