Skip to content

Commit ad5e082

Browse files
committed
Some more fixes
1 parent 25c2c06 commit ad5e082

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

_posts/2025-23-09-Supporting-AD-in-CMS-Combine-likelihood-scans.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,13 @@ achieve the stated objectives:
8989

9090
- Imported three pieces of code from Combine that handle the minimization
9191
procedures within the framework in RooFit's `RooMinimizer.cxx`.
92-
The first is the class `FreezeDisconnectedParametersRAII`,
92+
The first is a class imported by Jonas Rembser called `FreezeDisconnectedParametersRAII`,
9393
which automatically freezes and unfreezes parameters disconnected from
9494
the likelihood graph. The second is the function `generateOrthogonalCombinations`,
9595
which generates a list of index combinations by initializing a base configuration
9696
with all indices set to zero and then varying one category at a time.
97-
The third and final function is `reorderCombinations`, which takes the
98-
set of indices produced by `generateOrthogonalCombinations` and adjusts
97+
The third and final piece of code is a function called `reorderCombinations`,
98+
which takes the set of indices produced by `generateOrthogonalCombinations` and adjusts
9999
each combination by adding the corresponding base values modulo the
100100
maximum allowed index, effectively shifting the combinations relative
101101
to the current best indices.
@@ -104,8 +104,8 @@ achieve the stated objectives:
104104
which is the main minimization algorithm in Combine, was imported in
105105
`RooMinimizer.cxx`.
106106

107-
- Created a [tutorial](https://root.cern/doc/master/rf619__discrete__profiling_8py.html)
108-
and a [benchmark](https://github.com/vgvassilev/clad/issues/1521),
107+
- A [tutorial](https://root.cern/doc/master/rf619__discrete__profiling_8py.html) was created
108+
along with a [benchmark](https://github.com/vgvassilev/clad/issues/1521) ,made by Jonas Rembser,
109109
demonstrating discrete profiling with RooMultiPdf objects and evaluating
110110
the performance of AD in the likelihood scans.
111111

@@ -128,10 +128,10 @@ accurate optimization of both discrete and continuous parameters.
128128
gains from automatic differentiation.
129129

130130
- Additional optimization of Clad is needed to eliminate unnecessary overhead
131-
in gradient generation.
131+
in gradient generation.
132132

133133
- The discrete profiling logic implemented in RooMinimizer should be tested across
134-
different models to evaluate the minimizer’s behavior and robustness
134+
different models to evaluate the minimizer’s behavior and robustness.
135135

136136
## **Acknowledgements**
137137
would like to express my sincere gratitude to the CERN Summer School for

0 commit comments

Comments
 (0)