Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service: avoid unnecessary rescan #95

Open
nkostoulas opened this issue Jul 2, 2019 · 2 comments
Open

Service: avoid unnecessary rescan #95

nkostoulas opened this issue Jul 2, 2019 · 2 comments
Labels
Status: On Hold 💤

Comments

@nkostoulas
Copy link
Contributor

nkostoulas commented Jul 2, 2019 •
edited
Loading

Top-up address is imported (with rescan) on restart, which is unnecessary and slows down the service.
@nkostoulas nkostoulas self-assigned this Jul 2, 2019
@nkostoulas
Copy link
Contributor Author

nkostoulas commented Jul 3, 2019 •
edited
Loading

Proper solution would require getaddressinfo or getaddressbylabel RPCs which have not been implemented in btcsuite (btcsuite/btcd#1445).

I'm reluctant to use deprecated RPCs (validateaddress or any accounts related) as they will be removed soon.

Disabling rescan for now. It should be imported when mainstay first starts anyway, which would have no topup txs yet.

@nkostoulas nkostoulas added Type: Enhancement New feature or request and removed Status: Available ✔️ labels Jul 3, 2019
nkostoulas added a commit that referenced this issue Jul 3, 2019
@nkostoulas
Disable rescan on topup address import
648fc77 
(References #95)
@nkostoulas nkostoulas changed the title Service: avoid unnecessary import Service: avoid unnecessary rescan Jul 3, 2019
@nkostoulas nkostoulas removed their assignment Sep 10, 2019
@nkostoulas
Copy link
Contributor Author

There's also a rescanblockchain rpc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: On Hold 💤
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nkostoulas